diff options
| author | Reka Norman <rekanorman@google.com> | 2022-05-12 14:48:17 +1000 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-05-19 11:06:38 +0000 |
| commit | e46a9775418501ef77a646adf312975a936f0e51 (patch) | |
| tree | fe975434663e020cbfbc880594ecfeec2174b194 /src/mainboard/google/brya/variants/nereid | |
| parent | eb0c90aec52b1c62cd0e121940aee2375fc3f557 (diff) | |
mb/google/nissa: Rework LTE GPIO configuration
Currently, the LTE pins are enabled in gpio.c, then disabled in
fw_config.c if LTE is not present. However, since there's a short delay
between mainboard_init() and fw_config_handle(), this means that when
LTE is not present GPP_H19 (SOC_I2C_SUB_INT_ODL, used for the SAR
sensor) will be floating for a short period of time.
Rework the GPIO config so that the LTE pins are disabled in the
baseboard, then enabled in fw_config.c for variants using LTE. However,
this doesn't work for WWAN_EN and WWAN_RST_L since they need to be
enabled in bootblock. So these are instead enabled in the variant
gpio.c, then disabled in fw_config.c if LTE is not present.
BUG=None
TEST=LTE still works on nivviks
Change-Id: I9d8cbdff5a0dc9bdee87ee0971bc170409d925a2
Signed-off-by: Reka Norman <rekanorman@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64270
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
Reviewed-by: Kangheui Won <khwon@chromium.org>
Diffstat (limited to 'src/mainboard/google/brya/variants/nereid')
| -rw-r--r-- | src/mainboard/google/brya/variants/nereid/gpio.c | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/src/mainboard/google/brya/variants/nereid/gpio.c b/src/mainboard/google/brya/variants/nereid/gpio.c index 7e70ac4811..b472fe7de4 100644 --- a/src/mainboard/google/brya/variants/nereid/gpio.c +++ b/src/mainboard/google/brya/variants/nereid/gpio.c @@ -7,8 +7,6 @@ /* Pad configuration in ramstage */ static const struct pad_config override_gpio_table[] = { - /* A8 : WWAN_RF_DISABLE_ODL */ - PAD_NC(GPP_A8, NONE), /* A21 : GPP_A21 ==> USB_C1_AUX_DC_P */ PAD_CFG_GPO(GPP_A21, 0, DEEP), /* A22 : GPP_A22 ==> USB_C1_AUX_DC_N */ @@ -21,22 +19,13 @@ static const struct pad_config override_gpio_table[] = { /* D3 : WCAM_RST_L */ PAD_NC(GPP_D3, NONE), - /* D6 : WWAN_EN */ - PAD_NC(GPP_D6, NONE), /* D15 : EN_PP2800_WCAM_X */ PAD_NC(GPP_D15, NONE), /* D16 : EN_PP1800_PP1200_WCAM_X */ PAD_NC(GPP_D16, NONE), - /* F12 : WWAN_RST_L */ - PAD_NC(GPP_F12, NONE), - - /* H19 : SOC_I2C_SUB_INT_ODL */ - PAD_NC(GPP_H19, NONE), /* H22 : WCAM_MCLK_R */ PAD_NC(GPP_H22, NONE), - /* H23 : WWAN_SAR_DETECT_ODL */ - PAD_NC(GPP_H23, NONE), }; /* Early pad configuration in bootblock */ |