summaryrefslogtreecommitdiff
path: root/src/mainboard/google/brya/variants/craask
diff options
context:
space:
mode:
authorSubrata Banik <subratabanik@google.com>2023-09-05 18:51:23 +0000
committerFelix Held <felix-coreboot@felixheld.de>2023-09-07 13:37:41 +0000
commit2527e3f7edfa5fa5b25b6b3ddcf1b700af4d5fc8 (patch)
treef8a1c1e95dba452dbea6affde8836b61b9ae0fb1 /src/mainboard/google/brya/variants/craask
parentd3a89cdb749aad5bc378552eee3167003219b62d (diff)
soc/intel/meteorlake: Update LidStatus UPD dynamically
This patch ensures that the LidStatus UPD is passed a dynamic value, rather than always passing 1 (CONFIG_RUN_FSP_GOP enabled) for FSP 2.0 devices. Problem statement: * FSP-S GFX PEIM initializes the on-board display (eDP) even when the LID is physically closed, because LidStatus is always set to 1. * FSP-S skips external display initialization even when the LID is closed. Solution: * FSP-S GFX PEIM module understands the presence of an external display if LidStatus is not set, and tries to probe the other display endpoint. * Statically passing LidStatus as always enabled (aka 1) does not illustrate the exact device scenarios, so this patch updates LidStatus dynamically by reading the EC memory map offset. BUG=b:299137940 TEST=Able to build and boot google/rex to redirect the display using external HDMI monitor while LID is closed. Change-Id: I7d7b678227a6c8e32114de069af8455b8c1aa058 Signed-off-by: Subrata Banik <subratabanik@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/77685 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Diffstat (limited to 'src/mainboard/google/brya/variants/craask')
0 files changed, 0 insertions, 0 deletions