aboutsummaryrefslogtreecommitdiff
path: root/src/mainboard/google/brya/variants/baseboard/brask
diff options
context:
space:
mode:
authorMAULIK V VAGHELA <maulik.v.vaghela@intel.com>2021-08-06 18:49:56 +0530
committerNick Vaccaro <nvaccaro@google.com>2021-08-10 21:17:14 +0000
commit563a6cc6f2690f2594df51d8d16b3e9f4ef5ca8d (patch)
treef4f98746dbc83164b0c373ad73141efaaa4f00c3 /src/mainboard/google/brya/variants/baseboard/brask
parentbde3c56d2cd0fc117d8ab9a51e8b67ba0b73d090 (diff)
mb/*/brya/adlrvp: Remove hardcoding of BSP APIC ID
coreboot always assumes that BSP APIC ID will be 0 and core enumeration logic will look for lapic id from the mainboard. As per Intel 64 and IA-32 Architectures Software Developer’s Manual Volume 3: 8.4.1 BSP and AP Processors, this assumption might not hold true and we may have any other core as BSP. To handle this, we need to remove hardcoding of APIC ID 0 from mainboard. BUG=None BRANCH=None TEST=Check if there is no functional impact on the board. Change-Id: Ibc60494b0032a3139c1e6c79251fb2da750c8de8 Signed-off-by: MAULIK V VAGHELA <maulik.v.vaghela@intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/56852 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
Diffstat (limited to 'src/mainboard/google/brya/variants/baseboard/brask')
-rw-r--r--src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb b/src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb
index b6dbf4dc5b..162796159e 100644
--- a/src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb
+++ b/src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb
@@ -1,7 +1,6 @@
chip soc/intel/alderlake
- device cpu_cluster 0 on
- device lapic 0 on end
- end
+
+ device cpu_cluster 0 on end
# GPE configuration
register "pmc_gpe0_dw0" = "GPP_A"