aboutsummaryrefslogtreecommitdiff
path: root/src/mainboard/google/brya/variants/baseboard/brask
diff options
context:
space:
mode:
authorMAULIK V VAGHELA <maulik.v.vaghela@intel.com>2022-03-07 18:39:17 +0530
committerNick Vaccaro <nvaccaro@google.com>2022-03-15 18:10:41 +0000
commit215a97ee1c4cd87b266d63e32bf0b379e18fe849 (patch)
treec6ef1cae5509d9328198e9b468b55ad3e5d53791 /src/mainboard/google/brya/variants/baseboard/brask
parent6207a3967e0efeb0b52e24bc82b16e53085b6b9b (diff)
soc/intel/adl/chip.h: Convert all camel case variables to snake case
coreboot chip.h files mainly contains variable which allows board to fill platform configuration through devicetree. Since many of this configuration involves FSP UPDs, variable names were in camel case which aligned with UPD naming convention. By default coreboot follow snake case variable naming, so cleaning up file to align all variable names as per coreboot convention. During renaming process, this patch also removes unused variables listed below: -> SataEnable // Checked in SoC code based on PCI dev enabled status -> ITbtConnectTopologyTimeoutInMs // SoC always passes 0, so not used Note: Since separating out changes into smaller CL might break the compilation for the patch set, this is being pushed as a single big CL. BUG=None BRANCH=firmware-brya-14505.B TEST=All boards using ADL SoC compiles with the CL. Change-Id: Ieda567a89ec9287e3d988d489f3b3769dffcf9e0 Signed-off-by: Maulik V Vaghela <maulik.v.vaghela@intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/62645 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
Diffstat (limited to 'src/mainboard/google/brya/variants/baseboard/brask')
-rw-r--r--src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb20
-rw-r--r--src/mainboard/google/brya/variants/baseboard/brask/ramstage.c2
2 files changed, 11 insertions, 11 deletions
diff --git a/src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb b/src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb
index 9eb8bb2adb..a57289b46a 100644
--- a/src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb
+++ b/src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb
@@ -20,7 +20,7 @@ chip soc/intel/alderlake
register "tcc_offset" = "10" # TCC of 90
# Enable CNVi BT
- register "CnviBtCore" = "true"
+ register "cnvi_bt_core" = "true"
register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC0)" # USB2_C0
register "usb2_ports[1]" = "USB2_PORT_TYPE_C(OC1)" # USB2_C1
@@ -41,7 +41,7 @@ chip soc/intel/alderlake
register "tcss_ports[1]" = "TCSS_PORT_DEFAULT(OC1)"
register "tcss_ports[2]" = "TCSS_PORT_DEFAULT(OC2)"
- register "SerialIoI2cMode" = "{
+ register "serial_io_i2c_mode" = "{
[PchSerialIoIndexI2C0] = PchSerialIoPci,
[PchSerialIoIndexI2C1] = PchSerialIoPci,
[PchSerialIoIndexI2C2] = PchSerialIoDisabled,
@@ -50,12 +50,12 @@ chip soc/intel/alderlake
[PchSerialIoIndexI2C5] = PchSerialIoDisabled,
}"
- register "SerialIoGSpiMode" = "{
+ register "serial_io_gspi_mode" = "{
[PchSerialIoIndexGSPI0] = PchSerialIoDisabled,
[PchSerialIoIndexGSPI1] = PchSerialIoPci,
}"
- register "SerialIoUartMode" = "{
+ register "serial_io_uart_mode" = "{
[PchSerialIoIndexUART0] = PchSerialIoPci,
[PchSerialIoIndexUART1] = PchSerialIoDisabled,
[PchSerialIoIndexUART2] = PchSerialIoDisabled,
@@ -68,13 +68,13 @@ chip soc/intel/alderlake
register "pch_reset_power_cycle_duration" = "POWER_CYCLE_DURATION_1S"
# HD Audio
- register "PchHdaDspEnable" = "1"
- register "PchHdaIDispLinkTmode" = "HDA_TMODE_8T"
- register "PchHdaIDispLinkFrequency" = "HDA_LINKFREQ_96MHZ"
- register "PchHdaIDispCodecEnable" = "1"
+ register "pch_hda_dsp_enable" = "1"
+ register "pch_hda_idisp_link_tmode" = "HDA_TMODE_8T"
+ register "pch_hda_idisp_link_frequency" = "HDA_LINKFREQ_96MHZ"
+ register "pch_hda_idisp_codec_enable" = "1"
- # FIVR RFI Spread Spectrum 1.5%
- register "FivrSpreadSpectrum" = "FIVR_SS_1_5"
+ # FIVR RFI Spread Spectrum 1.5%
+ register "fivr_spread_spectrum" = "FIVR_SS_1_5"
# Intel Common SoC Config
#+-------------------+---------------------------+
diff --git a/src/mainboard/google/brya/variants/baseboard/brask/ramstage.c b/src/mainboard/google/brya/variants/baseboard/brask/ramstage.c
index 9628b447b0..4d30b8e237 100644
--- a/src/mainboard/google/brya/variants/baseboard/brask/ramstage.c
+++ b/src/mainboard/google/brya/variants/baseboard/brask/ramstage.c
@@ -146,7 +146,7 @@ void variant_update_psys_power_limits(const struct cpu_power_limits *limits,
/* voltage unit is milliVolts and current is in milliAmps */
soc_config->psys_pmax = (u16)(((u32)config_psys->psys_imax_ma * volts_mv) / 1000000);
- conf->PsysPmax = soc_config->psys_pmax;
+ conf->platform_pmax = soc_config->psys_pmax;
soc_config->tdp_pl2_override = pl2;
soc_config->tdp_psyspl2 = psyspl2;