diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2021-03-19 15:13:46 +0100 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2021-03-22 11:26:22 +0000 |
| commit | 88f94a9635cd64aaf6eeb3ed3991dceabcf6387a (patch) | |
| tree | fef34198fe0464e964e985d4889f9df747bd66b9 /src/mainboard/google/beltino/variants | |
| parent | d12d24b03930665be9ed9a16875577a770e6d7db (diff) | |
lynxpoint/broadwell: Rename LP GPIO config global
Do not use the same name as the non-LP GPIO config. This allows checking
at build-time that a mainboard uses the correct GPIO config format.
Without this commit, there are no build-time errors when using the wrong
format of GPIO config, but there would be undefined behavior at runtime.
Tested by trying to build asrock/b85m_pro4 and hp/folio_9480m after
toggling the `INTEL_LYNXPOINT_LP` Kconfig option (and trimming down the
USB config arrays for asrock/b85m_pro4). In both cases, building failed
because the necessary GPIO config global is not defined, as expected.
Change-Id: Ib06507ef8179da22bdb27593daf972e788051f3a
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51661
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google/beltino/variants')
5 files changed, 5 insertions, 5 deletions
diff --git a/src/mainboard/google/beltino/variants/mccloud/gpio.c b/src/mainboard/google/beltino/variants/mccloud/gpio.c index 91e808dd41..0f377acb7c 100644 --- a/src/mainboard/google/beltino/variants/mccloud/gpio.c +++ b/src/mainboard/google/beltino/variants/mccloud/gpio.c @@ -2,7 +2,7 @@ #include <southbridge/intel/lynxpoint/lp_gpio.h> -const struct pch_lp_gpio_map mainboard_gpio_map[] = { +const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = { LP_GPIO_UNUSED, /* 0: UNUSED */ LP_GPIO_UNUSED, /* 1: UNUSED */ LP_GPIO_UNUSED, /* 2: UNUSED */ diff --git a/src/mainboard/google/beltino/variants/monroe/gpio.c b/src/mainboard/google/beltino/variants/monroe/gpio.c index 4aead217df..b2af4cd2bb 100644 --- a/src/mainboard/google/beltino/variants/monroe/gpio.c +++ b/src/mainboard/google/beltino/variants/monroe/gpio.c @@ -2,7 +2,7 @@ #include <southbridge/intel/lynxpoint/lp_gpio.h> -const struct pch_lp_gpio_map mainboard_gpio_map[] = { +const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = { LP_GPIO_UNUSED, /* 0: UNUSED */ LP_GPIO_UNUSED, /* 1: UNUSED */ LP_GPIO_UNUSED, /* 2: UNUSED */ diff --git a/src/mainboard/google/beltino/variants/panther/gpio.c b/src/mainboard/google/beltino/variants/panther/gpio.c index 19e44e2ab1..438b771447 100644 --- a/src/mainboard/google/beltino/variants/panther/gpio.c +++ b/src/mainboard/google/beltino/variants/panther/gpio.c @@ -2,7 +2,7 @@ #include <southbridge/intel/lynxpoint/lp_gpio.h> -const struct pch_lp_gpio_map mainboard_gpio_map[] = { +const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = { LP_GPIO_UNUSED, /* 0: UNUSED */ LP_GPIO_UNUSED, /* 1: UNUSED */ LP_GPIO_UNUSED, /* 2: UNUSED */ diff --git a/src/mainboard/google/beltino/variants/tricky/gpio.c b/src/mainboard/google/beltino/variants/tricky/gpio.c index 809a4486ab..05394cd3b4 100644 --- a/src/mainboard/google/beltino/variants/tricky/gpio.c +++ b/src/mainboard/google/beltino/variants/tricky/gpio.c @@ -2,7 +2,7 @@ #include <southbridge/intel/lynxpoint/lp_gpio.h> -const struct pch_lp_gpio_map mainboard_gpio_map[] = { +const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = { LP_GPIO_UNUSED, /* 0: UNUSED */ LP_GPIO_UNUSED, /* 1: UNUSED */ LP_GPIO_UNUSED, /* 2: UNUSED */ diff --git a/src/mainboard/google/beltino/variants/zako/gpio.c b/src/mainboard/google/beltino/variants/zako/gpio.c index 15cb0c0c33..8f2e372386 100644 --- a/src/mainboard/google/beltino/variants/zako/gpio.c +++ b/src/mainboard/google/beltino/variants/zako/gpio.c @@ -2,7 +2,7 @@ #include <southbridge/intel/lynxpoint/lp_gpio.h> -const struct pch_lp_gpio_map mainboard_gpio_map[] = { +const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = { LP_GPIO_UNUSED, /* 0: UNUSED */ LP_GPIO_UNUSED, /* 1: UNUSED */ LP_GPIO_UNUSED, /* 2: UNUSED */ |