diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2021-06-23 14:39:32 +0200 |
|---|---|---|
| committer | Angel Pons <th3fanbus@gmail.com> | 2022-08-14 10:53:47 +0000 |
| commit | 333751b22e046793d84d72d1053b9c6aa2854d77 (patch) | |
| tree | 5750680fb5ba2834b7cff29ae813f145972b7b9b /src/mainboard/google/auron/spd.c | |
| parent | eb80d8da8862aa49b0b6b67e0166fa831f8f1343 (diff) | |
broadwell: Compute channel disable masks at runtime
Introduce the `SPD_MEMORY_DOWN` macro to indicate that a slot is used
with memory-down. This enables computing the channel disable masks as
the bits for slots where the SPD address is zero. To preserve current
behavior, zero the SPD addresses for memory-down slots afterwards.
Change-Id: I75b7be7c72062d1a26cfc7b09b79de62de0a9cea
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55807
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/google/auron/spd.c')
| -rw-r--r-- | src/mainboard/google/auron/spd.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/mainboard/google/auron/spd.c b/src/mainboard/google/auron/spd.c index 49ee42c5e1..686a24225e 100644 --- a/src/mainboard/google/auron/spd.c +++ b/src/mainboard/google/auron/spd.c @@ -104,9 +104,10 @@ void mainboard_fill_spd_data(struct pei_data *pei_data) const unsigned int spd_index = variant_get_spd_index(); fill_spd_for_index(pei_data->spd_data[0][0], spd_index); + pei_data->spd_addresses[0] = SPD_MEMORY_DOWN; - if (variant_is_dual_channel(spd_index)) + if (variant_is_dual_channel(spd_index)) { memcpy(pei_data->spd_data[1][0], pei_data->spd_data[0][0], SPD_LEN); - else - pei_data->dimm_channel1_disabled = 3; + pei_data->spd_addresses[2] = SPD_MEMORY_DOWN; + } } |