diff options
| author | Arthur Heymans <arthur@aheymans.xyz> | 2022-05-16 12:27:36 +0200 |
|---|---|---|
| committer | Martin L Roth <gaumless@tutanota.com> | 2022-05-28 04:17:47 +0000 |
| commit | 8d3640d22610eeb9a21c803d75c698e681a1dc62 (patch) | |
| tree | d544c971843f5b5c60dfe6efbdf456d6d701494c /src/mainboard/amd | |
| parent | 74782cb2f4601f5b67c6b169a7ab9b1d0778c638 (diff) | |
vendorcode/amd/agesa/f15tn: Fix all improper use of .data
AGESA has a lot of code in the .data section which is for initialized
data, that in fact should be .rodata. This adds the 'CONST' keyword
everywhere it is needed.
TEST: See in the .elf file (e.g. using readelf) that there is nothing in
.data section.
Change-Id: I9593c24f764319f66a64715d91175f64edf10608
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64386
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src/mainboard/amd')
| -rw-r--r-- | src/mainboard/amd/parmer/buildOpts.c | 2 | ||||
| -rw-r--r-- | src/mainboard/amd/thatcher/buildOpts.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/amd/parmer/buildOpts.c b/src/mainboard/amd/parmer/buildOpts.c index 030634605d..319c811042 100644 --- a/src/mainboard/amd/parmer/buildOpts.c +++ b/src/mainboard/amd/parmer/buildOpts.c @@ -47,7 +47,7 @@ #include "cpuLateInit.h" #include "GnbInterface.h" -GPIO_CONTROL parmer_gpio[] = { +CONST GPIO_CONTROL parmer_gpio[] = { {183, Function1, GpioIn | GpioOutEnB | PullUpB}, {-1} }; diff --git a/src/mainboard/amd/thatcher/buildOpts.c b/src/mainboard/amd/thatcher/buildOpts.c index 72390c0ae2..5f21d2e2f9 100644 --- a/src/mainboard/amd/thatcher/buildOpts.c +++ b/src/mainboard/amd/thatcher/buildOpts.c @@ -49,7 +49,7 @@ #define FCH_NO_XHCI_SUPPORT TRUE -GPIO_CONTROL thatcher_gpio[] = { +CONST GPIO_CONTROL thatcher_gpio[] = { {183, Function1, PullUpB}, {-1} }; |