diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2017-09-10 07:27:08 +0300 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2017-09-12 16:09:44 +0000 |
| commit | 6f55154cd75f67f8d7a737d36125353ce664fe30 (patch) | |
| tree | 5994b195926627ad7cc88b1a261697e3ae23d29b /src/mainboard/amd/inagua | |
| parent | fdf668795bc5f2351b96b876d30f66c56ccf6f2e (diff) | |
AGESA CIMX: Remove empty set_pcie_(de)reset
For boards with cimx/sb800, mainboards defined only empty
stubs. Reset functionality is handled as BiosCallout.
For amd/inagua, the defined function was actually initial
GPIO programming.
For cimx/sb700, function had prototypes but no callers.
For cimx/sb900, everything was commented out already.
Change-Id: I936feb4fc41d903078620c919a733bb9f39c3efb
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/21477
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/mainboard/amd/inagua')
| -rw-r--r-- | src/mainboard/amd/inagua/mainboard.c | 19 |
1 files changed, 3 insertions, 16 deletions
diff --git a/src/mainboard/amd/inagua/mainboard.c b/src/mainboard/amd/inagua/mainboard.c index f58c7d176d..8bc70be523 100644 --- a/src/mainboard/amd/inagua/mainboard.c +++ b/src/mainboard/amd/inagua/mainboard.c @@ -20,21 +20,8 @@ #include "SBPLATFORM.h" /* Platfrom Specific Definitions */ void broadcom_init(void); -void set_pcie_reset(void); -void set_pcie_dereset(void); -/** - * TODO - * SB CIMx callback - */ -void set_pcie_reset(void) -{ -} - -/** - * mainboard specific SB CIMx callback - */ -void set_pcie_dereset(void) +static void init_gpios(void) { /** * GPIO32 Pcie Device DeAssert for APU @@ -48,7 +35,7 @@ void set_pcie_dereset(void) */ /* Multi-function pins switch to GPIO0-35, these pins are shared with - * PCI pins, make sure Husson PCI device is disabled. + * PCI pins, make sure Hudson PCI device is disabled. */ RWMEM(ACPI_MMIO_BASE + PMIO_BASE + SB_PMIOA_REGEA, AccWidthUint8, ~BIT0, 1); @@ -71,7 +58,7 @@ static void mainboard_enable(device_t dev) printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); /* Inagua mainboard specific setting */ - set_pcie_dereset(); + init_gpios(); /* * Initialize ASF registers to an arbitrary address because someone |