diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2021-06-07 16:56:04 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2021-06-08 18:25:20 +0000 |
| commit | f7dbf4afd61fd54b4231685c1f3c1f39b20d996f (patch) | |
| tree | b32235a9e891c1b5f33e9987796361e005a2ec49 /src/include | |
| parent | f0c52768f38da98c3abecd294ec4904e48170315 (diff) | |
acpi: drop weak implementation of acpi_soc_get_bert_region
acpi_soc_get_bert_region only gets called when a chipset's Kconfig
selects the ACPI_BERT option in which case the chipset code needs to
implement this function. In the case of acpi_soc_get_bert_region not
being implemented, but ACPI_BERT being selected for a chipset this patch
changes the behavior from never generating a BERT ACPI table to a build
error which is more obvious and easier to catch.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Id479fce823d8534a7790f39125d1a2b3635fc029
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55277
Reviewed-by: Lance Zhao
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/acpi/acpi.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index b1eb664db2..9b73d5be29 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -1340,7 +1340,7 @@ unsigned long acpi_create_hest_error_source(acpi_hest_t *hest, void acpi_create_lpit(acpi_lpit_t *lpit); unsigned long acpi_create_lpi_desc_ncst(acpi_lpi_desc_ncst_t *lpi_desc, uint16_t uid); -/* For crashlog. */ +/* chipsets that select ACPI_BERT must implement this function */ enum cb_err acpi_soc_get_bert_region(void **region, size_t *length); /* For ACPI S3 support. */ |