summaryrefslogtreecommitdiff
path: root/src/ec
diff options
context:
space:
mode:
authorShelley Chen <shchen@google.com>2022-12-01 13:40:53 -0800
committerShelley Chen <shchen@google.com>2022-12-03 01:04:20 +0000
commite233fc7ac1425d54f5f237f6391d00141867836c (patch)
treebb7eb8352cbdd76ab8acfd393f98a5a9944a0b69 /src/ec
parentdddaeed4c142a23b05e68b1af77026bf7f2676e9 (diff)
mb/google/herobrine: NVMe id determined by logical (not physical) bit
NVMe is determined by a logical bit 1, not the physical SKU pin. Thus, (logical) sku_id & 0x2 == 0x2 would mean that the device has NVMe enabled on it. Previously, I thought that it was tied to a physical pin, but this is not correct. BUG=b:254281839 BRANCH=None TEST=flash and boot on villager and make sure that NVMe is not initialized in coreboot. Change-Id: Iaa75d2418d6a2351d874842e8678bd6ad3c92526 Signed-off-by: Shelley Chen <shchen@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/70230 Reviewed-by: Douglas Anderson <dianders@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/ec')
0 files changed, 0 insertions, 0 deletions