summaryrefslogtreecommitdiff
path: root/src/ec/system76
diff options
context:
space:
mode:
authorFelix Singer <felixsinger@posteo.net>2022-12-26 08:17:06 +0100
committerFelix Singer <felixsinger@posteo.net>2022-12-27 09:03:34 +0000
commitca4b587f95c0f1ed64e187511781abdfd4c7ebfb (patch)
treebc5c5a324c65b107fd6d992167168b0383a63503 /src/ec/system76
parentb4767ce169b202af2a9091275e30881172810fc6 (diff)
{superio,ec}/acpi: Replace constant "One" with actual number
Change-Id: I5c77b6d1e1dc1134f62dcb3e93df01dc9c2f386c Signed-off-by: Felix Singer <felixsinger@posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/71520 Reviewed-by: Elyes Haouas <ehaouas@noos.fr> Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/ec/system76')
-rw-r--r--src/ec/system76/ec/acpi/ac.asl2
-rw-r--r--src/ec/system76/ec/acpi/battery.asl6
-rw-r--r--src/ec/system76/ec/acpi/ec.asl2
-rw-r--r--src/ec/system76/ec/acpi/hid.asl6
-rw-r--r--src/ec/system76/ec/acpi/lid.asl2
-rw-r--r--src/ec/system76/ec/acpi/s76.asl2
6 files changed, 10 insertions, 10 deletions
diff --git a/src/ec/system76/ec/acpi/ac.asl b/src/ec/system76/ec/acpi/ac.asl
index 7326676198..b417e03c53 100644
--- a/src/ec/system76/ec/acpi/ac.asl
+++ b/src/ec/system76/ec/acpi/ac.asl
@@ -8,7 +8,7 @@ Device (AC)
_SB
})
- Name (ACFG, One)
+ Name (ACFG, 1)
Method (_PSR, 0, NotSerialized) // _PSR: Power Source
{
diff --git a/src/ec/system76/ec/acpi/battery.asl b/src/ec/system76/ec/acpi/battery.asl
index 027bbad0d6..d2857a53fa 100644
--- a/src/ec/system76/ec/acpi/battery.asl
+++ b/src/ec/system76/ec/acpi/battery.asl
@@ -30,10 +30,10 @@ Device (BAT0)
Name (PBIF, Package (0x0D)
{
- One, // 0 - Power Unit
+ 1, // 0 - Power Unit
0xFFFFFFFF, // 1 - Design Capacity
0xFFFFFFFF, // 2 - Last Full Charge Capacity
- One, // 3 - Battery Technology
+ 1, // 3 - Battery Technology
0xFFFFFFFF, // 4 - Design Voltage
Zero, // 5 - Design Capacity of Warning
Zero, // 6 - Design Capacity of Low
@@ -205,7 +205,7 @@ Device (BAT0)
}
Else
{
- Local0 |= One
+ Local0 |= 1
Local1 = (^^PCI0.LPCB.EC0.BPR0 & 0xFFFF)
}
diff --git a/src/ec/system76/ec/acpi/ec.asl b/src/ec/system76/ec/acpi/ec.asl
index b24137ca4f..ff245585c2 100644
--- a/src/ec/system76/ec/acpi/ec.asl
+++ b/src/ec/system76/ec/acpi/ec.asl
@@ -35,7 +35,7 @@ Device (\_SB.PCI0.LPCB.EC0)
Method (_REG, 2, Serialized) // _REG: Region Availability
{
Debug = Concatenate("EC: _REG", Concatenate(ToHexString(Arg0), Concatenate(" ", ToHexString(Arg1))))
- If ((Arg0 == 0x03) && (Arg1 == One)) {
+ If ((Arg0 == 0x03) && (Arg1 == 1)) {
// Enable hardware touchpad lock, airplane mode, and keyboard backlight keys
ECOS = 1
diff --git a/src/ec/system76/ec/acpi/hid.asl b/src/ec/system76/ec/acpi/hid.asl
index 6610c2e1bc..8bbb65bc45 100644
--- a/src/ec/system76/ec/acpi/hid.asl
+++ b/src/ec/system76/ec/acpi/hid.asl
@@ -25,7 +25,7 @@ Device (HIDD)
Method (HPEM, 1, Serialized)
{
- HBSY = One
+ HBSY = 1
HIDX = Arg0
Notify (HIDD, 0xC0)
@@ -36,11 +36,11 @@ Device (HIDD)
Local0++
}
- If (HBSY == One)
+ If (HBSY == 1)
{
HBSY = Zero
HIDX = Zero
- Return (One)
+ Return (1)
}
Else
{
diff --git a/src/ec/system76/ec/acpi/lid.asl b/src/ec/system76/ec/acpi/lid.asl
index 45e646acbb..26acc83462 100644
--- a/src/ec/system76/ec/acpi/lid.asl
+++ b/src/ec/system76/ec/acpi/lid.asl
@@ -10,7 +10,7 @@ Device (LID0)
If (^^PCI0.LPCB.EC0.ECOK) {
Return (^^PCI0.LPCB.EC0.LSTE)
} Else {
- Return (One)
+ Return (1)
}
}
diff --git a/src/ec/system76/ec/acpi/s76.asl b/src/ec/system76/ec/acpi/s76.asl
index 8db49df543..78614ee0ea 100644
--- a/src/ec/system76/ec/acpi/s76.asl
+++ b/src/ec/system76/ec/acpi/s76.asl
@@ -97,7 +97,7 @@ Device (S76D) {
Method (GKBL, 0, Serialized) {
Local0 = 0
If (^^PCI0.LPCB.EC0.ECOK) {
- ^^PCI0.LPCB.EC0.FDAT = One
+ ^^PCI0.LPCB.EC0.FDAT = 1
^^PCI0.LPCB.EC0.FCMD = 0xCA
Local0 = ^^PCI0.LPCB.EC0.FBUF
^^PCI0.LPCB.EC0.FCMD = Zero