diff options
| author | Felix Singer <felixsinger@posteo.net> | 2022-12-26 08:17:06 +0100 |
|---|---|---|
| committer | Felix Singer <felixsinger@posteo.net> | 2022-12-27 09:03:34 +0000 |
| commit | ca4b587f95c0f1ed64e187511781abdfd4c7ebfb (patch) | |
| tree | bc5c5a324c65b107fd6d992167168b0383a63503 /src/ec/lenovo/h8 | |
| parent | b4767ce169b202af2a9091275e30881172810fc6 (diff) | |
{superio,ec}/acpi: Replace constant "One" with actual number
Change-Id: I5c77b6d1e1dc1134f62dcb3e93df01dc9c2f386c
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/71520
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/ec/lenovo/h8')
| -rw-r--r-- | src/ec/lenovo/h8/acpi/ec.asl | 6 | ||||
| -rw-r--r-- | src/ec/lenovo/h8/acpi/thermal.asl | 4 | ||||
| -rw-r--r-- | src/ec/lenovo/h8/acpi/thinkpad.asl | 20 |
3 files changed, 15 insertions, 15 deletions
diff --git a/src/ec/lenovo/h8/acpi/ec.asl b/src/ec/lenovo/h8/acpi/ec.asl index 95841d3dd6..a1bf8bc5b7 100644 --- a/src/ec/lenovo/h8/acpi/ec.asl +++ b/src/ec/lenovo/h8/acpi/ec.asl @@ -69,7 +69,7 @@ Device(EC) if (^HKEY.INIT == 0) { ^HKEY.WBDC = BTEB ^HKEY.WWAN = WWEB - ^HKEY.INIT = One + ^HKEY.INIT = 1 } } } @@ -318,11 +318,11 @@ Device(EC) Method (FANE, 1, Serialized) { If (Arg0) { - FAND = One + FAND = 1 FANA = Zero } Else { FAND = Zero - FANA = One + FANA = 1 } } diff --git a/src/ec/lenovo/h8/acpi/thermal.asl b/src/ec/lenovo/h8/acpi/thermal.asl index 03abd758dd..6115eb687b 100644 --- a/src/ec/lenovo/h8/acpi/thermal.asl +++ b/src/ec/lenovo/h8/acpi/thermal.asl @@ -112,8 +112,8 @@ External (\PPKG, MethodObj) * in another ACPI scope. Call a method that does it! */ Method (_ON) { - \_SB.PCI0.LPCB.EC.FANE(One) - \FLVL = One + \_SB.PCI0.LPCB.EC.FANE(1) + \FLVL = 1 Notify (\_TZ.THM0, NOTIFY_TZ_TRIPPTCHG) } diff --git a/src/ec/lenovo/h8/acpi/thinkpad.asl b/src/ec/lenovo/h8/acpi/thinkpad.asl index fea97c15df..73eee52deb 100644 --- a/src/ec/lenovo/h8/acpi/thinkpad.asl +++ b/src/ec/lenovo/h8/acpi/thinkpad.asl @@ -51,7 +51,7 @@ Device (HKEY) /* Report event */ Method (RHK, 1, NotSerialized) { - Local0 = One << (Arg0 - 1) + Local0 = 1 << (Arg0 - 1) If (EMSK & Local0) { BTN = Arg0 Notify (HKEY, 0x80) @@ -60,7 +60,7 @@ Device (HKEY) /* Report tablet */ Method (RTAB, 1, NotSerialized) { - Local0 = One << (Arg0 - 1) + Local0 = 1 << (Arg0 - 1) If (ETAB & Local0) { BTAB = Arg0 Notify (HKEY, 0x80) @@ -84,7 +84,7 @@ Device (HKEY) /* Enable/disable event. */ Method (MHKM, 2, NotSerialized) { If (Arg0 <= 0x20) { - Local0 = One << (Arg0 - 1) + Local0 = 1 << (Arg0 - 1) If (Arg1) { DHKN |= Local0 @@ -159,10 +159,10 @@ Device (HKEY) */ Method (GBDC, 0) { - HAST = One + HAST = 1 If (HBDC) { - Local0 = One + Local0 = 1 If(\_SB.PCI0.LPCB.EC.BTEB) { Local0 |= 2 @@ -181,7 +181,7 @@ Device (HKEY) */ Method (SBDC, 1) { - HAST = One + HAST = 1 If (HBDC) { Local0 = (Arg0 & 2) >> 1 @@ -201,10 +201,10 @@ Device (HKEY) */ Method (GWAN, 0) { - HAST = One + HAST = 1 If (HWAN) { - Local0 = One + Local0 = 1 If(\_SB.PCI0.LPCB.EC.WWEB) { Local0 |= 2 @@ -223,7 +223,7 @@ Device (HKEY) */ Method (SWAN, 1) { - HAST = One + HAST = 1 If (HWAN) { Local0 = (Arg0 & 2) >> 1 @@ -270,7 +270,7 @@ Device (HKEY) Method (GUWB, 0) { If (HUWB) { - Local0 = One + Local0 = 1 If(\_SB.PCI0.LPCB.EC.UWBE) { Local0 |= 2 |