summaryrefslogtreecommitdiff
path: root/src/drivers
diff options
context:
space:
mode:
authorSubrata Banik <subrata.banik@intel.com>2021-10-29 21:46:32 +0530
committerSubrata Banik <subrata.banik@intel.com>2021-10-30 13:12:43 +0000
commitacbbbede42dd00f93d8b39603dc7c052b389c43f (patch)
tree1580aedbbc9ee07f35da61db243e5b70d2a53083 /src/drivers
parent53554369907ecbf85f95c7a57a96d290ce3b1aa5 (diff)
drivers/intel/fsp2_0: Check return type against CB_SUCCESS
commit 6af980a2a (drivers/intel/fsp2_0: Allow `mp_startup_all_cpus()` to run serially) drops CB_SUCCESS check for mp_run_on_all_aps function hence, this changes bring back the required return type against CB_SUCCESS. Change-Id: I9fc81e6a7eebbf0072ea2acb36b3c33539b517a7 Signed-off-by: Subrata Banik <subrata.banik@intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/58757 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'src/drivers')
-rw-r--r--src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c b/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c
index 5b537a9531..9aef1b6dce 100644
--- a/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c
+++ b/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c
@@ -108,7 +108,8 @@ efi_return_status_t mp_startup_all_cpus(efi_ap_procedure procedure,
* due to lack of acquiring a spin lock while accessing common data structure in
* multiprocessor environment.
*/
- if (mp_run_on_all_aps((void *)procedure, argument, timeout_usec, false)) {
+ if (mp_run_on_all_aps((void *)procedure, argument, timeout_usec, false) !=
+ CB_SUCCESS) {
printk(BIOS_DEBUG, "%s: Exit with Failure\n", __func__);
return FSP_NOT_STARTED;
}