summaryrefslogtreecommitdiff
path: root/src/drivers/wifi/generic
diff options
context:
space:
mode:
authorFurquan Shaikh <furquan@google.com>2020-10-04 12:13:07 -0700
committerFurquan Shaikh <furquan@google.com>2020-10-11 02:14:21 +0000
commit0af1926353d48242f03d6c80c6b2c8f646a3c145 (patch)
tree2f59f541218df51bdae7786e9980cc591899483f /src/drivers/wifi/generic
parent54b27169904538081f85f50a5a0873ba35d8ea16 (diff)
drivers/wifi: Drop maxsleep parameter from chip config
This change drops maxsleep parameter from chip config and instead hardcodes the deepest sleep state from which the WiFi device can wake the system up from to SLP_TYP_S3. This is similar to how other device drivers in coreboot report _PRW property in ACPI. It relieves the users from adding another register attribute to devicetree since all mainboards configure the same value. If this changes in the future, it should be easy to bring the maxsleep config parameter back. BUG=b:169802515 BRANCH=zork Change-Id: I42131fced008da0d51f0f777b7f2d99deaf68827 Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/46033 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Michael Niewöhner <foss@mniewoehner.de> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'src/drivers/wifi/generic')
-rw-r--r--src/drivers/wifi/generic/chip.h2
-rw-r--r--src/drivers/wifi/generic/generic.c2
2 files changed, 1 insertions, 3 deletions
diff --git a/src/drivers/wifi/generic/chip.h b/src/drivers/wifi/generic/chip.h
index fe3a1d1b99..02ab504daf 100644
--- a/src/drivers/wifi/generic/chip.h
+++ b/src/drivers/wifi/generic/chip.h
@@ -6,11 +6,9 @@
/**
* struct drivers_wifi_generic_config - Data structure to contain generic wifi config
* @wake: Wake pin for ACPI _PRW
- * @maxsleep: Maximum sleep state to wake from
*/
struct drivers_wifi_generic_config {
unsigned int wake;
- unsigned int maxsleep;
};
/**
diff --git a/src/drivers/wifi/generic/generic.c b/src/drivers/wifi/generic/generic.c
index 2ecaadc5f7..0705731e58 100644
--- a/src/drivers/wifi/generic/generic.c
+++ b/src/drivers/wifi/generic/generic.c
@@ -189,7 +189,7 @@ void wifi_generic_fill_ssdt(const struct device *dev,
/* Wake capabilities */
if (config)
- acpigen_write_PRW(config->wake, config->maxsleep);
+ acpigen_write_PRW(config->wake, ACPI_S3);
/* Fill regulatory domain structure */
if (CONFIG(HAVE_REGULATORY_DOMAIN)) {