diff options
| author | Julius Werner <jwerner@chromium.org> | 2022-01-21 17:06:20 -0800 |
|---|---|---|
| committer | Julius Werner <jwerner@chromium.org> | 2022-02-07 23:29:09 +0000 |
| commit | e9665959edeba6ae2d5364c4f7339704b6b6fd42 (patch) | |
| tree | e3cd9e0e6e91c9b6bd5c6f586a9abee1d654b5dd /src/drivers/net | |
| parent | 266041f0e62296737617cc2fcfa97f31e2b43aea (diff) | |
treewide: Remove "ERROR: "/"WARN: " prefixes from log messages
Now that the console system itself will clearly differentiate loglevels,
it is no longer necessary to explicitly add "ERROR: " in front of every
BIOS_ERR message to help it stand out more (and allow automated tooling
to grep for it). Removing all these extra .rodata characters should save
us a nice little amount of binary size.
This patch was created by running
find src/ -type f -exec perl -0777 -pi -e 's/printk\(\s*BIOS_ERR,\s*"ERROR: /printk\(BIOS_ERR, "/gi' '{}' ';'
and doing some cursory review/cleanup on the result. Then doing the same
thing for BIOS_WARN with
's/printk\(\s*BIOS_WARNING,\s*"WARN(ING)?: /printk\(BIOS_WARNING, "/gi'
Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: I3d0573acb23d2df53db6813cb1a5fc31b5357db8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61309
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Lance Zhao
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
Diffstat (limited to 'src/drivers/net')
| -rw-r--r-- | src/drivers/net/atl1e.c | 2 | ||||
| -rw-r--r-- | src/drivers/net/r8168.c | 7 |
2 files changed, 4 insertions, 5 deletions
diff --git a/src/drivers/net/atl1e.c b/src/drivers/net/atl1e.c index d5e0cdd61c..e44195c50f 100644 --- a/src/drivers/net/atl1e.c +++ b/src/drivers/net/atl1e.c @@ -30,7 +30,7 @@ static u8 get_hex_digit(const u8 c) ret = c - 'a' + 0x0a; } if (ret > 0x0f) { - printk(BIOS_ERR, "Error: Invalid hex digit found: " + printk(BIOS_ERR, "Invalid hex digit found: " "%c - 0x%02x\n", (char)c, c); ret = 0; } diff --git a/src/drivers/net/r8168.c b/src/drivers/net/r8168.c index 2299a99b02..51d4fcb0ab 100644 --- a/src/drivers/net/r8168.c +++ b/src/drivers/net/r8168.c @@ -76,7 +76,7 @@ static u8 get_hex_digit(const u8 c) ret = c - 'a' + 0x0a; } if (ret > 0x0f) { - printk(BIOS_ERR, "Error: Invalid hex digit found: " + printk(BIOS_ERR, "Invalid hex digit found: " "%c - 0x%02x\n", (char)c, c); ret = 0; } @@ -94,7 +94,7 @@ static enum cb_err fetch_mac_vpd_key(u8 *macstrbuf, const char *vpd_key) size_t offset; if (fmap_locate_area_as_rdev("RO_VPD", &rdev)) { - printk(BIOS_ERR, "Error: Couldn't find RO_VPD region."); + printk(BIOS_ERR, "Couldn't find RO_VPD region."); return CB_ERR; } search_address = rdev_mmap_full(&rdev); @@ -108,8 +108,7 @@ static enum cb_err fetch_mac_vpd_key(u8 *macstrbuf, const char *vpd_key) search_length); if (offset == search_length) { - printk(BIOS_ERR, - "Error: Could not locate '%s' in VPD\n", vpd_key); + printk(BIOS_ERR, "Could not locate '%s' in VPD\n", vpd_key); rdev_munmap(&rdev, search_address); return CB_ERR; } |