summaryrefslogtreecommitdiff
path: root/src/cpu
diff options
context:
space:
mode:
authorMarc Jones <marc.jones@amd.com>2007-05-10 23:22:27 +0000
committerStefan Reinauer <stepan@openbios.org>2007-05-10 23:22:27 +0000
commitddf845f620eb43d9ea2e8b0b265c321c6e797e6f (patch)
treeae8b74aa6ab4df81ec7061db6ab8c1cb941e8b58 /src/cpu
parent03625f4daf8bd92b8be64d795f8e46c01cc7468d (diff)
This patch cleans up and clarifies Geode source code comments.
Signed-off-by: Marc Jones <marc.jones@amd.com> Acked-by: Stefan Reinauer <stepan@coresystems.de> git-svn-id: svn://svn.coreboot.org/coreboot/trunk@2658 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/cpu')
-rw-r--r--src/cpu/amd/model_lx/cpureginit.c18
-rw-r--r--src/cpu/amd/model_lx/vsmsetup.c3
2 files changed, 6 insertions, 15 deletions
diff --git a/src/cpu/amd/model_lx/cpureginit.c b/src/cpu/amd/model_lx/cpureginit.c
index e4a29b9b78..2624b54836 100644
--- a/src/cpu/amd/model_lx/cpureginit.c
+++ b/src/cpu/amd/model_lx/cpureginit.c
@@ -101,11 +101,6 @@ void SetDelayControl(void)
;1 16 400MHz 0x82*10055 0x56960004 4
;
;2 4,4 400MHz 0x82710000 0x56960004 4
-;2 8,8 400MHz 0xC27100A5 0x56960004 4 *** OUT OF PUBLISHED ENVELOPE ***
-;
-;2 16,4 >333 0xB27100A5 0x56960004 4 *** OUT OF PUBLISHED ENVELOPE ***
-;2 16,8 >333 0xB27100A5 0x56960004 4 *** OUT OF PUBLISHED ENVELOPE ***
-;2 16,16 >333 0xB2710000 0x56960004 4 *** OUT OF PUBLISHED ENVELOPE ***
;
;1 4 <=333MHz 0x83*100FF 0x56960004 3
;1 8 <=333MHz 0x83*100AA 0x56960004 3
@@ -114,9 +109,6 @@ void SetDelayControl(void)
;2 4,4 <=333MHz 0x837100A5 0x56960004 3
;2 8,8 <=333MHz 0x937100A5 0x56960004 3
;
-;2 16,4 <=333MHz 0xB37100A5 0x56960004 3 *** OUT OF PUBLISHED ENVELOPE ***
-;2 16,8 <=333MHz 0xB37100A5 0x56960004 3 *** OUT OF PUBLISHED ENVELOPE ***
-;2 16,16 <=333MHz 0xB37100A5 0x56960004 3 *** OUT OF PUBLISHED ENVELOPE ***
;=========================================================================
;* - Bit 55 (disable SDCLK 1,3,5) should be set if there is a single DIMM in slot 0,
; but it should be clear for all 2 DIMM settings and if a single DIMM is in slot 1.
@@ -130,9 +122,9 @@ void SetDelayControl(void)
; DIMM Max MBUS
;DIMMs devices Frequency MCP 0x4C00000F Setting
;----- ------- --------- ----------------------
-;1 4 400MHz 0xF2F100FF 0x56960004 4 The MC changes improve Salsa.
-;1 8 400MHz 0xF2F100FF 0x56960004 4 Delay controls no real change,
-;1 4 <=333MHz 0xF2F100FF 0x56960004 3 just fixing typo in left side.
+;1 4 400MHz 0xF2F100FF 0x56960004 4 The No VTT changes improve timing.
+;1 8 400MHz 0xF2F100FF 0x56960004 4
+;1 4 <=333MHz 0xF2F100FF 0x56960004 3
;1 8 <=333MHz 0xF2F100FF 0x56960004 3
;1 16 <=333MHz 0xF2F100FF 0x56960004 3
*/
@@ -233,8 +225,8 @@ void cpuRegInit(void)
wrmsr(msrnum, msr);
/*
- ; Castle performance setting.
- ; Enable Quack for fewer re-RAS on the MC
+ * LX performance setting.
+ * Enable Quack for fewer re-RAS on the MC
*/
msrnum = GLIU0_ARB;
msr = rdmsr(msrnum);
diff --git a/src/cpu/amd/model_lx/vsmsetup.c b/src/cpu/amd/model_lx/vsmsetup.c
index 35c1381187..8ad0a3b41d 100644
--- a/src/cpu/amd/model_lx/vsmsetup.c
+++ b/src/cpu/amd/model_lx/vsmsetup.c
@@ -290,8 +290,7 @@ void do_vsmbios(void)
/* this is the base of rom on the LX at present. At some point, this has to be
* much better parameterized
*/
- /* the VSA starts at the base of rom - 64 */
- //rom = ((unsigned long) 0) - (ROM_SIZE + 64*1024);
+
//VSA is cat onto the end after LB builds
rom = ((unsigned long)0) - (ROM_SIZE + 36 * 1024);
buf = (unsigned char *)VSA2_BUFFER;