summaryrefslogtreecommitdiff
path: root/src/console/die.c
diff options
context:
space:
mode:
authorArthur Heymans <arthur@aheymans.xyz>2019-08-18 08:40:56 +0200
committerKyösti Mälkki <kyosti.malkki@gmail.com>2019-08-21 16:38:17 +0000
commit4c095fc9e91e68ab15d2ff256260acc9fd65dd91 (patch)
treefcf2f9f82ca790afd7efa6b79e573189b65d8f93 /src/console/die.c
parentc2741855afacd073d370d47818d972cca9baba18 (diff)
cpu/intel/car: Make stack guards more useful on C_ENV_BOOTBLOCK
With C_ENVIRONMENT_BOOTBLOCK, CONFIG_DCACHE_BSP_STACK_SIZE needs to be set to define a stack region that can be shared over all stages using CAR. It makes sense to use that Kconfig option's value instead of a hardcoded value. This will result in less false positives when the stack size is big, for instance with FSP using the coreboot stack. In many configurations with C_ENVIRONMENT_BOOTBLOCK the stack_base is at the base of CAR. If the stack grows too large it operates out of CAR, typically resulting in a hang. Therefore the stack guards are extended to cover 256 bytes at the base to at least provide a warning when the romstage is dangerously close of running out of stack. Change-Id: I2ce1dda4d1f254e6c36de4d3fea26e12c34195ff Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/34976 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/console/die.c')
0 files changed, 0 insertions, 0 deletions