summaryrefslogtreecommitdiff
path: root/src/arch/x86
diff options
context:
space:
mode:
authorJulius Werner <jwerner@chromium.org>2022-03-07 18:54:47 -0800
committerJulius Werner <jwerner@chromium.org>2022-03-09 17:20:48 +0000
commit797a110856a5d2021bbad0d28f4aee357d48cee1 (patch)
tree67fc076f4bc1750a62af8fcb12defa893d0641ca /src/arch/x86
parentd5f45d0a9e8f969181630ca4ba73f314f43728f0 (diff)
prog_loader: Change legacy_romstage_select_and_load() to return cb_err
This is passing through a cb_err from cbfs_prog_stage_load(), so it should be declared to return that as well. Signed-off-by: Julius Werner <jwerner@chromium.org> Change-Id: I5510d05953fe8c0e2cb511f01f862b66ced154ae Reviewed-on: https://review.coreboot.org/c/coreboot/+/62656 Reviewed-by: Yu-Ping Wu <yupingso@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/arch/x86')
-rw-r--r--src/arch/x86/bootblock_normal.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/arch/x86/bootblock_normal.c b/src/arch/x86/bootblock_normal.c
index 9341ac3325..4bc9b01332 100644
--- a/src/arch/x86/bootblock_normal.c
+++ b/src/arch/x86/bootblock_normal.c
@@ -12,7 +12,7 @@ static const char *get_fallback(const char *stagelist)
return ++stagelist;
}
-int legacy_romstage_select_and_load(struct prog *romstage)
+enum cb_err legacy_romstage_select_and_load(struct prog *romstage)
{
static const char *default_filenames = "normal/romstage\0fallback/romstage";
const char *boot_candidate;
@@ -24,8 +24,8 @@ int legacy_romstage_select_and_load(struct prog *romstage)
if (do_normal_boot()) {
romstage->name = boot_candidate;
- if (!cbfs_prog_stage_load(romstage))
- return 0;
+ if (cbfs_prog_stage_load(romstage) == CB_SUCCESS)
+ return CB_SUCCESS;
}
romstage->name = get_fallback(boot_candidate);