diff options
author | Subrata Banik <subratabanik@google.com> | 2024-05-16 15:19:22 +0530 |
---|---|---|
committer | Subrata Banik <subratabanik@google.com> | 2024-05-24 08:10:56 +0000 |
commit | 36e2b97e4cdaeb065265ed79b77f130747308b61 (patch) | |
tree | 837f3e011868e35113480ddffeff993892848c67 /payloads/libpayload/arch | |
parent | 814ae3b05507726938b0f9a9ba0c3a2a37e7b295 (diff) |
libpayload: Inject head.S into libc, remove separate class
Integrate head.S directly into libc and remove all instances of head.o.
* Drop 'separate class' entry for head.S.
* Drop special treament for head.o inside lpgcc.
* Change the .text in `x86/head.S` to `.section .text._entry`.
* Drop arch/mock/head.c, initially added as a dummy file.
Change-Id: I156d781908fcc38d455bbf9f2c29e5ab95c7775a
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/82478
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
Diffstat (limited to 'payloads/libpayload/arch')
-rw-r--r-- | payloads/libpayload/arch/arm/Makefile.mk | 3 | ||||
-rw-r--r-- | payloads/libpayload/arch/arm64/Makefile.mk | 5 | ||||
-rw-r--r-- | payloads/libpayload/arch/mock/Makefile.mk | 2 | ||||
-rw-r--r-- | payloads/libpayload/arch/mock/head.c | 3 | ||||
-rw-r--r-- | payloads/libpayload/arch/x86/Makefile.mk | 2 | ||||
-rw-r--r-- | payloads/libpayload/arch/x86/head.S | 2 |
6 files changed, 5 insertions, 12 deletions
diff --git a/payloads/libpayload/arch/arm/Makefile.mk b/payloads/libpayload/arch/arm/Makefile.mk index f71138baaa..e6574e7782 100644 --- a/payloads/libpayload/arch/arm/Makefile.mk +++ b/payloads/libpayload/arch/arm/Makefile.mk @@ -29,7 +29,7 @@ CFLAGS += -mthumb -march=armv7-a arm_asm_flags = -Wa,-mthumb -Wa,-mimplicit-it=always -Wa,-mno-warn-deprecated -head.o-y += head.S +libc-y += head.S libc-y += eabi_compat.c libc-y += main.c sysinfo.c libc-y += timer.c coreboot.c util.S @@ -44,5 +44,4 @@ libc-$(CONFIG_LP_GPL) += memcpy.S memset.S memmove.S libgdb-y += gdb.c # Add other classes here when you put assembly files into them! -head.o-S-ccopts += $(arm_asm_flags) libc-S-ccopts += $(arm_asm_flags) diff --git a/payloads/libpayload/arch/arm64/Makefile.mk b/payloads/libpayload/arch/arm64/Makefile.mk index b478c77bce..d6cc51efdf 100644 --- a/payloads/libpayload/arch/arm64/Makefile.mk +++ b/payloads/libpayload/arch/arm64/Makefile.mk @@ -29,7 +29,7 @@ CFLAGS += -march=armv8-a arm64_asm_flags = -head.o-y += head.S +libc-y += head.S libc-y += main.c sysinfo.c libc-y += timer.c coreboot.c util.S libc-y += virtual.c @@ -42,5 +42,4 @@ libc-y += mmu.c libgdb-y += gdb.c # Add other classes here when you put assembly files into them! - head.o-S-ccopts += $(arm64_asm_flags) - libc-S-ccopts += $(arm64_asm_flags) +libc-S-ccopts += $(arm64_asm_flags) diff --git a/payloads/libpayload/arch/mock/Makefile.mk b/payloads/libpayload/arch/mock/Makefile.mk index e3f10a69ed..0b418f0d97 100644 --- a/payloads/libpayload/arch/mock/Makefile.mk +++ b/payloads/libpayload/arch/mock/Makefile.mk @@ -1,7 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-only -head.o-y += head.c - libc-y += virtual.c CFLAGS += -Wno-address-of-packed-member diff --git a/payloads/libpayload/arch/mock/head.c b/payloads/libpayload/arch/mock/head.c deleted file mode 100644 index 55a691f910..0000000000 --- a/payloads/libpayload/arch/mock/head.c +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -/* This file is empty on purpose. It should not be used. */ diff --git a/payloads/libpayload/arch/x86/Makefile.mk b/payloads/libpayload/arch/x86/Makefile.mk index 196415d7a2..d2c33b4fb8 100644 --- a/payloads/libpayload/arch/x86/Makefile.mk +++ b/payloads/libpayload/arch/x86/Makefile.mk @@ -30,7 +30,7 @@ ifneq ($(CONFIG_LP_COMPILER_LLVM_CLANG),y) CFLAGS += -mpreferred-stack-boundary=2 endif -head.o-y += head.S +libc-y += head.S libc-y += main.c sysinfo.c libc-y += timer.c coreboot.c util.S libc-y += exec.S virtual.c diff --git a/payloads/libpayload/arch/x86/head.S b/payloads/libpayload/arch/x86/head.S index 99842cd54b..26ba901d5a 100644 --- a/payloads/libpayload/arch/x86/head.S +++ b/payloads/libpayload/arch/x86/head.S @@ -29,7 +29,7 @@ .code32 .global _entry - .text + .section .text._entry .align 4 /* |