diff options
author | Keith Short <keithshort@chromium.org> | 2019-04-19 14:02:02 -0600 |
---|---|---|
committer | Patrick Georgi <pgeorgi@google.com> | 2019-04-23 10:21:24 +0000 |
commit | 00dbf449c929933d7cdb31140d609269c68d3671 (patch) | |
tree | 16662f2e41cd6885ffe0b779fe944f48f3879241 /payloads/external/Yabits | |
parent | c5d734b3f9a8cc2e6df8f5e6c111f0fe32201ad3 (diff) |
coreboot: Run mainboard specific code before Cr50 reset
When coreboot checks the TPM and key-ladder state it issues a reboot of
the Cr50 with a delay parameter. Older Cr50 code doesn't support the
delay parameter and reboots immediately, which prevented coreboot from
running the mainboard specific code needed for the AP to come back up.
This change calls mainboard_prepare_cr50_reset() prior to sending the
VENDOR_CC_IMMEDIATE_RESET command.
This change also fixes a false error message from the coreboot log that
indicated "Unexpected Cr50 TPM mode 3" when the Cr50 key ladder is
disabled.
BUG=b:130830178
BRANCH=none
TEST=build coreboot on sarien and grunt platforms.
TEST=Load Cr50 v3.15, run 'gsctool -a -m disable; reboot'. Verify
corebot send the
VENDOR_CC_IMMEDIATE_RESET command and that the AP boots normally.
Verify event log shows "cr50 Reset Required"
TEST=Force Cr50 automatic update. Verify event log shows "cr50 Update
Reset".
Change-Id: Ib05c9cfde8e87daffd4233114263de5b30822872
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32365
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'payloads/external/Yabits')
0 files changed, 0 insertions, 0 deletions