summaryrefslogtreecommitdiff
path: root/Documentation/gerrit_guidelines.md
diff options
context:
space:
mode:
authorArthur Heymans <arthur@aheymans.xyz>2017-04-05 16:17:26 +0200
committerArthur Heymans <arthur@aheymans.xyz>2017-12-16 10:00:10 +0000
commit3cf94032bced9345f4b9d71b7d2becab4dfcd530 (patch)
tree49546878d13dc164f18db96fe6cc1ddc914d3026 /Documentation/gerrit_guidelines.md
parentcb0c40d3503badee7939393360903ebdc904609a (diff)
nb/x4x/raminit: Rewrite SPD decode and timing selection
This is mostly written from scratch and uses common spd ddr2 decode functions. This improves the following: * This fixes incorrect CAS/Freq detection on DDR2; * Fixes tRFC computation; tRFC == 78 is a valid timing which is excluded and 0 ends up being used; (TESTED) * Timings selection does not use loops; * Removes ddr3 spd decode and is re-added in follow-up patches using common ddr3 spd functions; * Raminit would bail out if a dimm was unsupported, now in some cases it just marks the dimm slot as empty; * It dramatically reduces stack usage since it does not allocate 4 times 256 bytes to store full SPDs, amongs other unused things that were stored in sysinfo; * Reports when no dimms are present; * Uses i2c block read to read SPD which is about 5 times faster than bytewise read, with a fallback to smbus mode in case of failure, which does seem to happen when the system is forcefully powered off. Change-Id: I760eeaa3bd4f2bc25a517ddb1b9533c971454071 Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-on: https://review.coreboot.org/19143 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Martin Roth <martinroth@google.com>
Diffstat (limited to 'Documentation/gerrit_guidelines.md')
0 files changed, 0 insertions, 0 deletions