summaryrefslogtreecommitdiff
path: root/COPYING
diff options
context:
space:
mode:
authorMartin Roth <gaumless@gmail.com>2023-09-11 13:40:55 -0600
committerFelix Held <felix-coreboot@felixheld.de>2023-09-13 15:26:01 +0000
commit22e16db4c5e2125409abc77b888493e63bbeea86 (patch)
treea69bde5745ab3fa998f7328c7eeaab19954d213b /COPYING
parent3c4e0ad5616dd6f8090c2a3bc0fe013a80a4040e (diff)
acpi/soundwire.[ch]: Fix dpn entry array overrun
In soundwire.h, SOUNDWIRE_DPN MIN & MAX are set to 1 and 14. When creating the dpn array, the length was set to MAX - MIN or 13, numbered 0 to 12. When accessing the array, the code was bailing out if a value greater than MAX was trying to be accessed, so the array was able to be overrun by two structure lengths. Fix this problem by: 1) Not subtracting the MIN value when creating the array, which does waste a little space. If anyone wants to refactor the code to fix that, please feel free. 2) Breaking out of the loop when the port is equal to the MAX port number instead of just when it's greater than the max port number. Reported-by: Coverity (CID:1429766 & CID:1429771) Signed-off-by: Martin Roth <gaumless@gmail.com> Change-Id: I0841bb8c9869fe9f53958f05614848785a98b766 Reviewed-on: https://review.coreboot.org/c/coreboot/+/77777 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Tim Wawrzynczak <inforichland@gmail.com>
Diffstat (limited to 'COPYING')
0 files changed, 0 insertions, 0 deletions