diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2021-07-30 03:26:15 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2021-07-31 01:29:18 +0000 |
| commit | f80e6d6f567b8f47e32b3f54b846802825510bf9 (patch) | |
| tree | 0892a2cb3dea36392a3d15056c2fb677d526e7b0 | |
| parent | df566ae4280a9a604b89aedb3469eab1b5ef05c7 (diff) | |
soc/amd/common/block/gpio_banks: use unsigned int for gevent parameter
A valid GEVENT number is never negative. The local variable in
set_single_gpio still needs to be a signed integer, since the return
value of get_gpio_gevent being -1 indicates that the GPIO can't generate
a GEVENT. The check for that makes the function return before calling
program_smi of program_sci, so the parameter of those functions can be
changed to unsigned.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I6ce23ceed1585589932824b8cab2a138328672a9
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56705
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/soc/amd/common/block/gpio_banks/gpio.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/amd/common/block/gpio_banks/gpio.c b/src/soc/amd/common/block/gpio_banks/gpio.c index 8cfca8b216..8f84cb67fc 100644 --- a/src/soc/amd/common/block/gpio_banks/gpio.c +++ b/src/soc/amd/common/block/gpio_banks/gpio.c @@ -27,7 +27,7 @@ static int get_gpio_gevent(gpio_t gpio, const struct soc_amd_event *table, return -1; } -static void program_smi(uint32_t flags, int gevent_num) +static void program_smi(uint32_t flags, unsigned int gevent_num) { uint8_t level; @@ -52,7 +52,7 @@ static void program_smi(uint32_t flags, int gevent_num) * In a similar fashion, polarity (rising/falling, hi/lo) of each GPE is * represented as a single bit in SMI_SCI_TRIG register. */ -static void program_sci(uint32_t flags, int gevent_num) +static void program_sci(uint32_t flags, unsigned int gevent_num) { struct sci_source sci; |