diff options
| author | Michał Żygowski <michal.zygowski@3mdeb.com> | 2022-11-07 19:23:47 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-02-23 12:18:24 +0000 |
| commit | ecfdb43afacfb32c3a632288747afd705c89ba87 (patch) | |
| tree | 5254043fcf6f1c1d1eb2095c5c0f366825c91c99 | |
| parent | 2e495b09d52f83622c83258059de8f5c92b3ef6b (diff) | |
soc/intel/elkhartlake/gpio.c: Fix GPD reset map
The reset bit mapping was incorrectly assigned to GPIO groups. The
reset mapping for Community 0 actually reflects the GPD reset mapping.
Change the Community 0 reset mapping to the correct default map and fix
the GPD reset mapping.
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Change-Id: I2b9d093ca7ea0f5087f49671ca457c0b45927918
Reviewed-on: https://review.coreboot.org/c/coreboot/+/72406
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Mario Scheithauer <mario.scheithauer@siemens.com>
Reviewed-by: Lean Sheng Tan <sheng.tan@9elements.com>
| -rw-r--r-- | src/soc/intel/elkhartlake/gpio.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/soc/intel/elkhartlake/gpio.c b/src/soc/intel/elkhartlake/gpio.c index d329b52029..1b07bc5d27 100644 --- a/src/soc/intel/elkhartlake/gpio.c +++ b/src/soc/intel/elkhartlake/gpio.c @@ -11,7 +11,7 @@ static const struct reset_mapping rst_map[] = { { .logical = PAD_CFG0_LOGICAL_RESET_PLTRST, .chipset = 2U << 30 }, }; -static const struct reset_mapping rst_map_com0[] = { +static const struct reset_mapping rst_map_gpd[] = { { .logical = PAD_CFG0_LOGICAL_RESET_PWROK, .chipset = 0U << 30 }, { .logical = PAD_CFG0_LOGICAL_RESET_DEEP, .chipset = 1U << 30 }, { .logical = PAD_CFG0_LOGICAL_RESET_PLTRST, .chipset = 2U << 30 }, @@ -88,8 +88,8 @@ static const struct pad_community ehl_communities[TOTAL_GPIO_COMM] = { .max_pads_per_group = GPIO_MAX_NUM_PER_GROUP, .name = "GPP_BTG", .acpi_path = "\\_SB.PCI0.GPIO", - .reset_map = rst_map_com0, - .num_reset_vals = ARRAY_SIZE(rst_map_com0), + .reset_map = rst_map, + .num_reset_vals = ARRAY_SIZE(rst_map), .groups = ehl_community0_groups, .num_groups = ARRAY_SIZE(ehl_community0_groups), }, @@ -130,8 +130,8 @@ static const struct pad_community ehl_communities[TOTAL_GPIO_COMM] = { .max_pads_per_group = GPIO_MAX_NUM_PER_GROUP, .name = "GPD", .acpi_path = "\\_SB.PCI0.GPIO", - .reset_map = rst_map, - .num_reset_vals = ARRAY_SIZE(rst_map), + .reset_map = rst_map_gpd, + .num_reset_vals = ARRAY_SIZE(rst_map_gpd), .groups = ehl_community2_groups, .num_groups = ARRAY_SIZE(ehl_community2_groups), }, |