diff options
author | Angel Pons <th3fanbus@gmail.com> | 2021-02-19 20:28:20 +0100 |
---|---|---|
committer | Angel Pons <th3fanbus@gmail.com> | 2021-03-01 19:40:57 +0000 |
commit | ec1b37decc207f95f7d0cd9680d1f2aab4b9d1c5 (patch) | |
tree | 9e39412a1bd9908b02aaeaad1e23344b3c1f4a7b | |
parent | 4ace49c9a292c0caf040fd542299932fac4c9734 (diff) |
soc/intel/{skl,icl}: Move tco_configure() to bootblock
Backport commit 03ed5bff5c (soc/intel/cannonlake: Move tco_configure to
bootblock), commit bb50c67227 (soc/intel/tigerlake: Move tco_configure
to bootblock) and commit 60c619f6a3 (soc/intel/jasperlake: Move
tco_configure to bootblock) to other platforms. This is for consistency.
Change-Id: I31fd0ceb67eacf30aefa457d757bf0d7f4cd7e87
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50946
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r-- | src/soc/intel/icelake/bootblock/bootblock.c | 4 | ||||
-rw-r--r-- | src/soc/intel/icelake/romstage/pch.c | 4 | ||||
-rw-r--r-- | src/soc/intel/skylake/bootblock/bootblock.c | 4 | ||||
-rw-r--r-- | src/soc/intel/skylake/romstage/pch.c | 4 |
4 files changed, 8 insertions, 8 deletions
diff --git a/src/soc/intel/icelake/bootblock/bootblock.c b/src/soc/intel/icelake/bootblock/bootblock.c index 9f360daf00..df1fb56234 100644 --- a/src/soc/intel/icelake/bootblock/bootblock.c +++ b/src/soc/intel/icelake/bootblock/bootblock.c @@ -2,6 +2,7 @@ #include <bootblock_common.h> #include <intelblocks/systemagent.h> +#include <intelblocks/tco.h> #include <intelblocks/uart.h> #include <soc/bootblock.h> @@ -25,4 +26,7 @@ void bootblock_soc_init(void) { report_platform_info(); bootblock_pch_init(); + + /* Program TCO_BASE_ADDRESS and TCO Timer Halt */ + tco_configure(); } diff --git a/src/soc/intel/icelake/romstage/pch.c b/src/soc/intel/icelake/romstage/pch.c index 6b134c0681..d3c2554425 100644 --- a/src/soc/intel/icelake/romstage/pch.c +++ b/src/soc/intel/icelake/romstage/pch.c @@ -1,14 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <intelblocks/smbus.h> -#include <intelblocks/tco.h> #include <soc/romstage.h> void romstage_pch_init(void) { - /* Programming TCO_BASE_ADDRESS and TCO Timer Halt */ - tco_configure(); - /* Program SMBUS_BASE_ADDRESS and Enable it */ smbus_common_init(); } diff --git a/src/soc/intel/skylake/bootblock/bootblock.c b/src/soc/intel/skylake/bootblock/bootblock.c index 6380db2e1f..1e5f105274 100644 --- a/src/soc/intel/skylake/bootblock/bootblock.c +++ b/src/soc/intel/skylake/bootblock/bootblock.c @@ -3,6 +3,7 @@ #include <bootblock_common.h> #include <intelblocks/systemagent.h> #include <intelblocks/gspi.h> +#include <intelblocks/tco.h> #include <intelblocks/uart.h> #include <soc/bootblock.h> @@ -33,4 +34,7 @@ void bootblock_soc_init(void) report_platform_info(); bootblock_pch_init(); gspi_early_bar_init(); + + /* Program TCO_BASE_ADDRESS and TCO Timer Halt */ + tco_configure(); } diff --git a/src/soc/intel/skylake/romstage/pch.c b/src/soc/intel/skylake/romstage/pch.c index c85bdd667f..f94d611abe 100644 --- a/src/soc/intel/skylake/romstage/pch.c +++ b/src/soc/intel/skylake/romstage/pch.c @@ -1,14 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <intelblocks/smbus.h> -#include <intelblocks/tco.h> #include <soc/romstage.h> void romstage_pch_init(void) { - /* Program TCO_BASE_ADDRESS and TCO Timer Halt */ - tco_configure(); - /* Program SMBUS_BASE_ADDRESS and enable it */ smbus_common_init(); } |