aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2022-08-10 16:34:47 +0200
committerFelix Held <felix-coreboot@felixheld.de>2022-08-15 18:31:38 +0000
commitebc36c1b48cc91cb96b6435cc768a6a5e7043c90 (patch)
tree89a5d9eac6b5085d8c7e6ea2b7cddef6905dd2d5
parentd1a42b6fa92ed2c6a03e7a9ad8bbfd9fe8988e91 (diff)
soc/amd/common/fsp/fsp-acpi: rework HOB pointer validity check
Checking if the return value of the fsp_find_extension_hob_by_guid call is NULL should make the code a bit easier to read. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: I6bdb07eab6da80f46c57f5d7b3c894b41ac23b8a Reviewed-on: https://review.coreboot.org/c/coreboot/+/66699 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Raul Rangel <rrangel@chromium.org>
-rw-r--r--src/soc/amd/common/fsp/fsp-acpi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/soc/amd/common/fsp/fsp-acpi.c b/src/soc/amd/common/fsp/fsp-acpi.c
index f92d571066..8ddf7d4295 100644
--- a/src/soc/amd/common/fsp/fsp-acpi.c
+++ b/src/soc/amd/common/fsp/fsp-acpi.c
@@ -23,7 +23,7 @@ uintptr_t add_agesa_fsp_acpi_table(guid_t guid, const char *name, acpi_rsdp_t *r
size_t hob_size;
data = fsp_find_extension_hob_by_guid(guid.b, &hob_size);
- if (!data) {
+ if (data == NULL) {
printk(BIOS_ERR, "AGESA %s ACPI table was not found.\n", name);
return current;
}