diff options
| author | Liju-Clr Chen <liju-clr.chen@mediatek.com> | 2022-11-21 18:36:36 +0800 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-11-23 16:31:29 +0000 |
| commit | e1ee23f29d9b0ca86bc29b540efa9290d7b40cb0 (patch) | |
| tree | 499bd97d7372029149c707b5ac63d54b2e50bba4 | |
| parent | 977673894ff486af2ff74ba5585ca6039701eb8f (diff) | |
soc/mediatek: Add error handling for dptx_get_edid()
Skip eDP initialization when we failed to get EDID. This prevents the
PLL assertion in dp_intf_config() if the display could not be
initialized properly.
BUG=b:233720142
TEST=boot to depthcharge on MT8188 EVB.
Change-Id: I0fd672b175feb9b813c1d9ec4140e4273079ff07
Signed-off-by: Liju-Clr Chen <liju-clr.chen@mediatek.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69858
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Reviewed-by: Yidi Lin <yidilin@google.com>
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/soc/mediatek/common/dp/dptx.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/soc/mediatek/common/dp/dptx.c b/src/soc/mediatek/common/dp/dptx.c index f2c0905cc4..08d288acf8 100644 --- a/src/soc/mediatek/common/dp/dptx.c +++ b/src/soc/mediatek/common/dp/dptx.c @@ -1111,7 +1111,10 @@ int mtk_edp_init(struct edid *edid) dptx_check_sinkcap(&mtk_edp); - dptx_get_edid(&mtk_edp, edid); + if (dptx_get_edid(&mtk_edp, edid) != 0) { + printk(BIOS_ERR, "Failed to get EDID\n"); + return -1; + } dptx_set_trainingstart(&mtk_edp); dp_intf_config(edid); |