diff options
| author | Furquan Shaikh <furquan@google.com> | 2020-07-02 16:37:17 -0700 |
|---|---|---|
| committer | Furquan Shaikh <furquan@google.com> | 2020-07-05 18:33:53 +0000 |
| commit | dfd7e9d560b24a193e8bcfb51782e99e6c4a9142 (patch) | |
| tree | 0fc70b8bcb4216cfc80594c79ea090e7295933eb | |
| parent | ee68b88babe604527e944224740fc2c6161cb351 (diff) | |
ec/google/chromeec: Move if EC_GOOGLE_CHROMEEC to i2c_tunnel/Kconfig
This change moves `if EC_GOOGLE_CHROMEEC` from chromeec/Kconfig to
chromeec/i2c_tunnel/Kconfig. This is done to make it clear that the
Kconfig file in i2c_tunnel is sourced unconditionally, but the configs
in i2c_tunnel/Kconfig are conditionally defined based on the
evaluation of if condition.
This change addressed the feedback received on
https://review.coreboot.org/c/coreboot/+/40515/11/src/ec/google/chromeec/Kconfig#200.
Change-Id: I66cd91d6b1813ff6d0fb7be719e2da65ac6ac23b
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43040
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/ec/google/chromeec/Kconfig | 4 | ||||
| -rw-r--r-- | src/ec/google/chromeec/i2c_tunnel/Kconfig | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/src/ec/google/chromeec/Kconfig b/src/ec/google/chromeec/Kconfig index 461587800b..638c011a58 100644 --- a/src/ec/google/chromeec/Kconfig +++ b/src/ec/google/chromeec/Kconfig @@ -197,8 +197,4 @@ config EC_GOOGLE_CHROMEEC_SWITCHES Enable support for Chrome OS mode switches provided by the Chrome OS EC. -if EC_GOOGLE_CHROMEEC - source "src/ec/google/chromeec/*/Kconfig" - -endif diff --git a/src/ec/google/chromeec/i2c_tunnel/Kconfig b/src/ec/google/chromeec/i2c_tunnel/Kconfig index 20169fde0f..232725566b 100644 --- a/src/ec/google/chromeec/i2c_tunnel/Kconfig +++ b/src/ec/google/chromeec/i2c_tunnel/Kconfig @@ -1,6 +1,10 @@ +if EC_GOOGLE_CHROMEEC + config EC_GOOGLE_CHROMEEC_I2C_TUNNEL bool depends on HAVE_ACPI_TABLES help This enables the Cros EC I2C tunnel driver that is required to fill the SSDT nodes for the I2C tunnel used by the mainboard. + +endif |