diff options
| author | Subrata Banik <subratabanik@google.com> | 2022-12-10 19:23:06 +0530 |
|---|---|---|
| committer | Subrata Banik <subratabanik@google.com> | 2022-12-14 06:33:09 +0000 |
| commit | decb9717cec1db5b9898615003b0efff114131c3 (patch) | |
| tree | c6eeae655dbdb3def8e16dfda8df28f1541d9bb8 | |
| parent | 988d3eefa65faf704fe59152308ad2797af0f263 (diff) | |
soc/intel/meteorlake: Enable VMX and VTD
Drops the `FIXME` comment and relevant code as this patch enables
VMX and VTD.
This patch also fixes the problem of additional reboot on every warm
boot due to overriding the CPU soft-strap.
TEST=No extra reboot seen while issuing warm reset from kernel
console.
without this patch:
950:calling FspMemoryInit 1,225,259 (20,537)
951:returning from FspMemoryInit 10,334,707 (9, 109,447)
with this patch:
950:calling FspMemoryInit 1,225,259 (20,537)
951:returning from FspMemoryInit 1,334,707 (109,447)
Change-Id: Ib130698e7255876c5a12abc93dd7d8a34dfae968
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70553
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/soc/intel/meteorlake/romstage/fsp_params.c | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/src/soc/intel/meteorlake/romstage/fsp_params.c b/src/soc/intel/meteorlake/romstage/fsp_params.c index d104cb3bc1..add927dfa6 100644 --- a/src/soc/intel/meteorlake/romstage/fsp_params.c +++ b/src/soc/intel/meteorlake/romstage/fsp_params.c @@ -263,15 +263,6 @@ static void fill_fspm_usb4_params(FSP_M_CONFIG *m_cfg, static void fill_fspm_vtd_params(FSP_M_CONFIG *m_cfg, const struct soc_intel_meteorlake_config *config) { - const uint32_t cpuid = cpu_get_cpuid(); - - /* FIXME: Enable Vtd back when kernel cmdline needs it. */ - if (cpuid == CPUID_METEORLAKE_A0_1 || cpuid == CPUID_METEORLAKE_A0_2) { - m_cfg->VtdDisable = 1; - m_cfg->VmxEnable = 0; - return; - } - m_cfg->VtdDisable = 0; m_cfg->VtdBaseAddress[0] = GFXVT_BASE_ADDRESS; m_cfg->VtdBaseAddress[1] = VTVC0_BASE_ADDRESS; |