diff options
| author | Duncan Laurie <dlaurie@chromium.org> | 2017-02-24 12:28:12 -0800 |
|---|---|---|
| committer | Duncan Laurie <dlaurie@chromium.org> | 2017-02-25 18:19:50 +0100 |
| commit | d4d6ba180d718b073379000b480dc3f468581955 (patch) | |
| tree | f0f6e9a6f6e998d44e4f36bb7bc092f2d4de6409 | |
| parent | 6a489237d5686828f26d7e452824374df7fb5708 (diff) | |
google/eve: Add rise/fall times for I2C buses
Apply tuning for the PCH I2C buses on Eve based on rise/fall time
measurements that were done with a scope.
BUG=chrome-os-partner:59686
BRANCH=none
TEST=Manual testing on Eve P1 to verify that all devices on I2C
buses are still functional. Post-tuning measurement will be done
once a new firmware is released.
Change-Id: I3d70ff455a20ecda374d7e7fa6cd3ab15e7f2621
Signed-off-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-on: https://review.coreboot.org/18487
Tested-by: build bot (Jenkins)
Reviewed-by: Furquan Shaikh <furquan@google.com>
| -rw-r--r-- | src/mainboard/google/eve/devicetree.cb | 28 |
1 files changed, 24 insertions, 4 deletions
diff --git a/src/mainboard/google/eve/devicetree.cb b/src/mainboard/google/eve/devicetree.cb index e5ac17f738..0de7a263f7 100644 --- a/src/mainboard/google/eve/devicetree.cb +++ b/src/mainboard/google/eve/devicetree.cb @@ -162,12 +162,16 @@ chip soc/intel/skylake register "usb3_ports[2]" = "USB3_PORT_EMPTY" # Empty register "usb3_ports[3]" = "USB3_PORT_EMPTY" # Empty - register "i2c_voltage[0]" = "I2C_VOLTAGE_3V3" # Touchscreen - register "i2c_voltage[1]" = "I2C_VOLTAGE_3V3" # TPM - register "i2c_voltage[2]" = "I2C_VOLTAGE_1V8" # Touchpad - register "i2c_voltage[4]" = "I2C_VOLTAGE_1V8" # Audio + # Touchscreen + register "i2c_voltage[0]" = "I2C_VOLTAGE_3V3" + register "i2c[0]" = "{ + .speed = I2C_SPEED_FAST_PLUS, + .rise_time_ns = 17, + .fall_time_ns = 38, + }" # Enable I2C1 bus early for TPM access + register "i2c_voltage[1]" = "I2C_VOLTAGE_3V3" register "i2c[1]" = "{ .early_init = 1, .speed = I2C_SPEED_FAST, @@ -175,6 +179,22 @@ chip soc/intel/skylake .fall_time_ns = 32, }" + # Touchpad + register "i2c_voltage[2]" = "I2C_VOLTAGE_1V8" + register "i2c[2]" = "{ + .speed = I2C_SPEED_FAST, + .rise_time_ns = 247, + .fall_time_ns = 17, + }" + + # Audio + register "i2c_voltage[4]" = "I2C_VOLTAGE_1V8" + register "i2c[4]" = "{ + .speed = I2C_SPEED_FAST, + .rise_time_ns = 240, + .fall_time_ns = 30, + }" + # Must leave UART0 enabled or SD/eMMC will not work as PCI register "SerialIoDevMode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoPci, |