diff options
| author | Patrick Georgi <patrick@georgi-clan.de> | 2013-06-09 08:05:45 +0200 |
|---|---|---|
| committer | Patrick Georgi <patrick@georgi-clan.de> | 2013-06-09 08:34:45 +0200 |
| commit | d2e0dd5bc1002a45ef16b92203850df217233bec (patch) | |
| tree | 8ab574ce6871b495cfda09a3f5435062b6acbf6e | |
| parent | ecbc0c5cb9c2dd403a2464ddc53ec937931d8cc6 (diff) | |
buildgcc: Re-add some break statements
While some of the case .. break statement actually weren't needed,
too are, since otherwise the option parsing loop hangs.
Exit conditions for that endless loop: "--" or no more arguments,
in line with GNU command line parsing rules.
Change-Id: I0dbc35e530fb8c93a0f7de05ac47f325555ad4a4
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/3418
Tested-by: build bot (Jenkins)
Reviewed-by: David Hubbard <david.c.hubbard+coreboot@gmail.com>
| -rwxr-xr-x | util/crossgcc/buildgcc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 1d8e54c771..4458ea4228 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -215,9 +215,9 @@ while true ; do -G|--gdb) shift; SKIPGDB=0;; -S|--scripting) shift; SKIPPYTHON=0;; -y|--ccache) shift; USECCACHE=1;; - --) shift;; + --) shift; break;; -*) printf "Invalid option\n\n"; myhelp; exit 1;; - *) ;; + *) break;; esac done |