diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2021-07-13 19:03:29 +0200 |
|---|---|---|
| committer | Tim Wawrzynczak <twawrzynczak@chromium.org> | 2021-07-14 21:26:34 +0000 |
| commit | afab34c3720f673a7edebefe6615ff622253d93e (patch) | |
| tree | 665c160b6d8e0ecb36c02366e41b9ea512658a44 | |
| parent | 275ade9539cd315cf72c4126ebcce714dc3102ee (diff) | |
drivers/usb/acpi: Replace unneeded `memcpy` use
A regular assignment works just as well and also allows type-checking.
It also avoids a common mistake where `sizeof` is applied to a pointer
to obtain the size of the data it points to, without dereferencing it.
Found-by: Coverity CID 1458231
Change-Id: I7ed05322c3c911f3da4145f81e4d9760a275fec2
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56265
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/drivers/usb/acpi/usb_acpi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/drivers/usb/acpi/usb_acpi.c b/src/drivers/usb/acpi/usb_acpi.c index a0dadff861..8ada939138 100644 --- a/src/drivers/usb/acpi/usb_acpi.c +++ b/src/drivers/usb/acpi/usb_acpi.c @@ -132,7 +132,7 @@ bool usb_acpi_get_pld(const struct device *usb_device, struct acpi_pld *pld) return false; if (config->use_custom_pld) - memcpy(pld, &config->custom_pld, sizeof(pld)); + *pld = config->custom_pld; else acpi_pld_fill_usb(pld, config->type, &config->group); |