diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2017-07-30 13:47:06 +0300 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2017-08-07 12:34:54 +0000 |
| commit | ab1d2ac626d0535191b5f612707ae8f22c46c538 (patch) | |
| tree | 695c3a34cc41702a1da8a9ebe2eb79f235c718bb | |
| parent | d4ce1ded0174c2f2866e57023a68c6854f78e8a1 (diff) | |
usbdebug: Remove redundant setup
Taking ownership is handled with DBGP_OWNER within
usbdebug driver code.
Change-Id: Ia5da10d385cda1b4968f812967ea8a54d7e3c974
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/20824
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: David Guckian <david.guckian@intel.com>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
| -rw-r--r-- | src/soc/intel/broadwell/Kconfig | 4 | ||||
| -rw-r--r-- | src/soc/intel/broadwell/usb_debug.c | 7 | ||||
| -rw-r--r-- | src/southbridge/intel/fsp_rangeley/Kconfig | 4 |
3 files changed, 0 insertions, 15 deletions
diff --git a/src/soc/intel/broadwell/Kconfig b/src/soc/intel/broadwell/Kconfig index 51322012d0..9d6f978a67 100644 --- a/src/soc/intel/broadwell/Kconfig +++ b/src/soc/intel/broadwell/Kconfig @@ -185,10 +185,6 @@ config EHCI_BAR hex default 0xd8000000 -config EHCI_DEBUG_OFFSET - hex - default 0xa0 - config SERIRQ_CONTINUOUS_MODE bool default y diff --git a/src/soc/intel/broadwell/usb_debug.c b/src/soc/intel/broadwell/usb_debug.c index fffebf00c6..683b4cc522 100644 --- a/src/soc/intel/broadwell/usb_debug.c +++ b/src/soc/intel/broadwell/usb_debug.c @@ -41,8 +41,6 @@ void pci_ehci_dbg_set_port(pci_devfn_t dev, unsigned int port) void pci_ehci_dbg_enable(pci_devfn_t dev, unsigned long base) { - u32 tmp32; - if (!dev) return; @@ -51,9 +49,4 @@ void pci_ehci_dbg_enable(pci_devfn_t dev, unsigned long base) /* Enable access to the EHCI memory space registers. */ pci_write_config8(dev, PCI_COMMAND, PCI_COMMAND_MEMORY); - - /* Force ownership of hte Debug Port to the EHCI controller. */ - tmp32 = read32((void *)(base + CONFIG_EHCI_DEBUG_OFFSET)); - tmp32 |= (1 << 30); - write32((void *)(base + CONFIG_EHCI_DEBUG_OFFSET), tmp32); } diff --git a/src/southbridge/intel/fsp_rangeley/Kconfig b/src/southbridge/intel/fsp_rangeley/Kconfig index 4d2e89f316..ab85ec4c97 100644 --- a/src/southbridge/intel/fsp_rangeley/Kconfig +++ b/src/southbridge/intel/fsp_rangeley/Kconfig @@ -37,10 +37,6 @@ config EHCI_BAR hex default 0xfef00000 -config EHCI_DEBUG_OFFSET - hex - default 0xa0 - config SERIRQ_CONTINUOUS_MODE bool default n |