aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorElyes Haouas <ehaouas@noos.fr>2022-11-30 07:51:11 +0100
committerFelix Held <felix-coreboot@felixheld.de>2022-12-02 14:44:41 +0000
commita521d66116ce178d36f94b794c4546f090a40a8b (patch)
treeef87d1c743b1df35814f7e430354b8f12845b561
parent5a845ee894802bb214503a70e05bc0eb31c19a15 (diff)
nb/intel/i945: Use boolean for gpu_lvds_use_spread_spectrum_clock
Change-Id: I5f11bde99dfcde81c9dc62c1102330c0a6c16e04 Signed-off-by: Elyes Haouas <ehaouas@noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/70149 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
-rw-r--r--src/mainboard/apple/macbook21/devicetree.cb2
-rw-r--r--src/mainboard/lenovo/t60/devicetree.cb2
-rw-r--r--src/mainboard/lenovo/x60/devicetree.cb2
-rw-r--r--src/northbridge/intel/i945/chip.h3
4 files changed, 5 insertions, 4 deletions
diff --git a/src/mainboard/apple/macbook21/devicetree.cb b/src/mainboard/apple/macbook21/devicetree.cb
index 833d658ccb..a7832efeb1 100644
--- a/src/mainboard/apple/macbook21/devicetree.cb
+++ b/src/mainboard/apple/macbook21/devicetree.cb
@@ -5,7 +5,7 @@ chip northbridge/intel/i945
register "gfx" = "GMA_STATIC_DISPLAYS(0)"
register "gpu_hotplug" = "0x00000220"
- register "gpu_lvds_use_spread_spectrum_clock" = "1"
+ register "gpu_lvds_use_spread_spectrum_clock" = "true"
register "pwm_freq" = "180"
register "gpu_panel_power_up_delay" = "250"
register "gpu_panel_power_backlight_on_delay" = "2380"
diff --git a/src/mainboard/lenovo/t60/devicetree.cb b/src/mainboard/lenovo/t60/devicetree.cb
index c77af6bb26..7a9e9aec9d 100644
--- a/src/mainboard/lenovo/t60/devicetree.cb
+++ b/src/mainboard/lenovo/t60/devicetree.cb
@@ -5,7 +5,7 @@ chip northbridge/intel/i945
register "gfx" = "GMA_STATIC_DISPLAYS(0)"
register "gpu_hotplug" = "0x00000220"
- register "gpu_lvds_use_spread_spectrum_clock" = "1"
+ register "gpu_lvds_use_spread_spectrum_clock" = "true"
register "pwm_freq" = "275"
register "gpu_panel_power_up_delay" = "250"
register "gpu_panel_power_backlight_on_delay" = "2380"
diff --git a/src/mainboard/lenovo/x60/devicetree.cb b/src/mainboard/lenovo/x60/devicetree.cb
index d56ec514aa..a41749a64a 100644
--- a/src/mainboard/lenovo/x60/devicetree.cb
+++ b/src/mainboard/lenovo/x60/devicetree.cb
@@ -5,7 +5,7 @@ chip northbridge/intel/i945
register "gfx" = "GMA_STATIC_DISPLAYS(0)"
register "gpu_hotplug" = "0x00000220"
- register "gpu_lvds_use_spread_spectrum_clock" = "1"
+ register "gpu_lvds_use_spread_spectrum_clock" = "true"
register "pwm_freq" = "180"
register "gpu_panel_power_up_delay" = "250"
register "gpu_panel_power_backlight_on_delay" = "2380"
diff --git a/src/northbridge/intel/i945/chip.h b/src/northbridge/intel/i945/chip.h
index 0de0e58f9f..8153462dc4 100644
--- a/src/northbridge/intel/i945/chip.h
+++ b/src/northbridge/intel/i945/chip.h
@@ -4,6 +4,7 @@
#define NORTHBRIDGE_INTEL_I945_CHIP_H
#include <drivers/intel/gma/i915.h>
+#include <types.h>
struct northbridge_intel_i945_config {
/* In units of 100us timer */
@@ -17,7 +18,7 @@ struct northbridge_intel_i945_config {
u32 gpu_hotplug;
u32 pwm_freq;
- int gpu_lvds_use_spread_spectrum_clock;
+ bool gpu_lvds_use_spread_spectrum_clock;
struct i915_gpu_controller_info gfx;
int pci_mmio_size;
};