summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKarthikeyan Ramasubramanian <kramasub@google.com>2022-05-02 13:38:23 -0600
committerTim Wawrzynczak <twawrzynczak@chromium.org>2022-05-12 18:40:18 +0000
commita2bba5b5f1f4bfaa21ea3e6b9cdc98ce17ca75e7 (patch)
treec26cf08f347e7e62997b086fa40ec540cc8f8caf
parentd52adc4a87ba54c0b20ec66eff5433a393bc1688 (diff)
mb/google/skyrim/var/skyrim: Add USB WWAN configuration
Add Fibcom FM101-GL USB WWAN configuration with the required power sequence as suggested in Fibocom FM101-GL Hardware Guide V1.0. BUG=b:227761300 TEST=Build and boot to OS in Skyrim. Ensure that the WWAN module is enumerated in the output of lsusb. localhost ~ # lsusb Bus 004 Device 003: ID 2cb7:01a2 Fibocom Wireless Inc. Fibocom FM101-GL Module Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com> Change-Id: I39f8e7204e31d9a4d093aacd838a18e6d2f44970 Reviewed-on: https://review.coreboot.org/c/coreboot/+/64004 Reviewed-by: Raul Rangel <rrangel@chromium.org> Reviewed-by: Jon Murphy <jpmurphy@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/mainboard/google/skyrim/variants/baseboard/gpio.c2
-rw-r--r--src/mainboard/google/skyrim/variants/skyrim/overridetree.cb17
2 files changed, 18 insertions, 1 deletions
diff --git a/src/mainboard/google/skyrim/variants/baseboard/gpio.c b/src/mainboard/google/skyrim/variants/baseboard/gpio.c
index 41d6bbe42f..1390e0958f 100644
--- a/src/mainboard/google/skyrim/variants/baseboard/gpio.c
+++ b/src/mainboard/google/skyrim/variants/baseboard/gpio.c
@@ -24,7 +24,7 @@ static const struct soc_amd_gpio base_gpio_table[] = {
/* WLAN_AUX_RST_L */
PAD_GPO(GPIO_7, HIGH),
/* EN_PWR_WWAN_X */
- PAD_GPO(GPIO_8, HIGH),
+ PAD_GPO(GPIO_8, LOW),
/* EN_PP3300_WLAN */
PAD_GPO(GPIO_9, HIGH),
/* BT_DISABLE */
diff --git a/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb b/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb
index dd731ee24d..3e4d552883 100644
--- a/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb
+++ b/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb
@@ -45,6 +45,17 @@ chip soc/amd/sabrina
register "group" = "ACPI_PLD_GROUP(2, 2)"
device usb 3.0 on end
end
+ chip drivers/usb/acpi
+ register "desc" = ""WWAN""
+ register "type" = "UPC_TYPE_INTERNAL"
+ register "group" = "ACPI_PLD_GROUP(2, 2)"
+ register "has_power_resource" = "1"
+ register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_42)"
+ register "reset_off_delay_ms" = "20"
+ register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_8)"
+ register "enable_delay_ms" = "20"
+ device usb 3.1 on end
+ end
end # VL822 USB3 hub
end
end # USB 3.1 port3
@@ -62,6 +73,12 @@ chip soc/amd/sabrina
register "group" = "ACPI_PLD_GROUP(2, 2)"
device usb 2.0 on end
end
+ chip drivers/usb/acpi
+ register "desc" = ""WWAN""
+ register "type" = "UPC_TYPE_INTERNAL"
+ register "group" = "ACPI_PLD_GROUP(2, 2)"
+ device usb 2.1 on end
+ end
end # VL822 USB2 hub
end
end # USB 2 port3