summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRichard Spiegel <richard.spiegel@silverbackltd.com>2018-02-20 08:35:39 -0700
committerPatrick Georgi <pgeorgi@google.com>2018-02-26 15:06:36 +0000
commit99fd08d324c6a6da4149f95f9d78da0fc769c289 (patch)
tree9a4a91de9dc9a7164efabcc1dba323cfd7c1672b
parent3ca534f302b1d7cc76db485c01faeae59c9f1adf (diff)
soc/amd/common/block/pi/amd_late_init.c: Fix part number
Kahlee DIMM have invalid string when it comes to part number (bytes 0x149-0x15c). We currently force a NA string, but grunt has the proper strings. Just let the string go through, and a second commit within smbios.c will be responsible for testing the string and taking proper action. BUG=b:73122207 TEST=Build, boot and record serial output for kahlee while injecting different strings to dmi17->PartNumber. Remove string injection before committing. Change-Id: I427262873f9ec80f459245e5f509e28a68de3074 Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com> Reviewed-on: https://review.coreboot.org/23825 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Martin Roth <martinroth@google.com>
-rw-r--r--src/soc/amd/common/block/pi/amd_late_init.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/amd/common/block/pi/amd_late_init.c b/src/soc/amd/common/block/pi/amd_late_init.c
index 9d0bb269b8..ffb54acc22 100644
--- a/src/soc/amd/common/block/pi/amd_late_init.c
+++ b/src/soc/amd/common/block/pi/amd_late_init.c
@@ -49,8 +49,8 @@ static void transfer_memory_info(TYPE17_DMI_INFO *dmi17, struct dimm_info *dimm)
dimm->bus_width = dmi17->DataWidth;
dimm->mod_id = dmi17->ManufacturerIdCode;
dimm->bank_locator = 0;
- strncpy((char *)dimm->module_part_number, "NA",
- sizeof(dimm->module_part_number));
+ strncpy((char *)dimm->module_part_number, dmi17->PartNumber,
+ sizeof(dimm->module_part_number));
}
static void prepare_dmi_17(void *unused)