summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatt DeVillier <matt.devillier@gmail.com>2023-01-26 14:37:44 -0600
committerEric Lai <eric_lai@quanta.corp-partner.google.com>2023-02-10 08:28:20 +0000
commit8a1de830162983a717665858bc8a51d1057ce85d (patch)
treefe5ac513214f4fd0d899d8bb390cc818f58722e0
parentb3034ebae2c1a4c36d7f6b9a55222cf13ed1d11c (diff)
drivers/net/r8168: Demote MAC lookup printk from error to warn
Some older devices use the vpd key 'ethernet_mac' vs 'ethernet_mac0' for the first/only LAN NIC, so don't treat the key lookup as an error. If no MAC is able to be found, another error will be printed later in the driver init. TEST=build/boot google/fizz, dump cbmem log, verify 'ethernet_mac0' lookup failure printk output at warning level. Change-Id: If5226f4686a819a7020fd14f130181420ee1462b Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/72475 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
-rw-r--r--src/drivers/net/r8168.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/drivers/net/r8168.c b/src/drivers/net/r8168.c
index 8f070bd349..dcf863a4dd 100644
--- a/src/drivers/net/r8168.c
+++ b/src/drivers/net/r8168.c
@@ -109,7 +109,7 @@ static enum cb_err fetch_mac_vpd_key(u8 *macstrbuf, const char *vpd_key)
search_length);
if (offset == search_length) {
- printk(BIOS_ERR, "Could not locate '%s' in VPD\n", vpd_key);
+ printk(BIOS_WARNING, "Could not locate '%s' in VPD\n", vpd_key);
rdev_munmap(&rdev, search_address);
return CB_ERR;
}