summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSean Rhodes <sean@starlabs.systems>2023-01-06 11:20:30 +0000
committerFelix Held <felix-coreboot@felixheld.de>2023-04-26 12:05:42 +0000
commit854bd492fcfa01901fbf8ac39b539b55a7b45ba5 (patch)
tree3ece5fe64014ce11134600d01b009e11cbe796f4
parentd45402a55a6866ea1b34ce6d85a88f970c250467 (diff)
mb/{system76,msi}: Enable PchHdaAudioLinkHdaEnable via devicetree
Signed-off-by: Sean Rhodes <sean@starlabs.systems> Change-Id: Iae2dc0a934f0ea3ca59d8a811f1daeedb090a7bd Reviewed-on: https://review.coreboot.org/c/coreboot/+/71717 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Michał Kopeć <michal.kopec@3mdeb.com>
-rw-r--r--src/mainboard/msi/ms7d25/devicetree.cb1
-rw-r--r--src/mainboard/msi/ms7d25/romstage_fsp_params.c1
-rw-r--r--src/mainboard/system76/adl/devicetree.cb1
-rw-r--r--src/mainboard/system76/adl/variants/darp8/romstage.c1
-rw-r--r--src/mainboard/system76/adl/variants/galp6/romstage.c1
5 files changed, 2 insertions, 3 deletions
diff --git a/src/mainboard/msi/ms7d25/devicetree.cb b/src/mainboard/msi/ms7d25/devicetree.cb
index 189faf6f9e..d50a950ab6 100644
--- a/src/mainboard/msi/ms7d25/devicetree.cb
+++ b/src/mainboard/msi/ms7d25/devicetree.cb
@@ -261,6 +261,7 @@ chip soc/intel/alderlake
device ref p2sb on end
device ref hda on
subsystemid 0x1462 0x9d25
+ register "pch_hda_audio_link_hda_enable" = "1"
register "pch_hda_dsp_enable" = "0"
register "pch_hda_idisp_link_tmode" = "HDA_TMODE_8T"
register "pch_hda_idisp_link_frequency" = "HDA_LINKFREQ_96MHZ"
diff --git a/src/mainboard/msi/ms7d25/romstage_fsp_params.c b/src/mainboard/msi/ms7d25/romstage_fsp_params.c
index 707f871cc5..9a18f13ddf 100644
--- a/src/mainboard/msi/ms7d25/romstage_fsp_params.c
+++ b/src/mainboard/msi/ms7d25/romstage_fsp_params.c
@@ -57,7 +57,6 @@ void mainboard_memory_init_params(FSPM_UPD *memupd)
memupd->FspmConfig.DmiMaxLinkSpeed = 4; // Gen4 speed, undocumented
memupd->FspmConfig.SkipExtGfxScan = 0;
- memupd->FspmConfig.PchHdaAudioLinkHdaEnable = 1;
memupd->FspmConfig.PchHdaSdiEnable[0] = 1;
/*
diff --git a/src/mainboard/system76/adl/devicetree.cb b/src/mainboard/system76/adl/devicetree.cb
index 8f668bee33..d469491884 100644
--- a/src/mainboard/system76/adl/devicetree.cb
+++ b/src/mainboard/system76/adl/devicetree.cb
@@ -84,6 +84,7 @@ chip soc/intel/alderlake
end
device ref p2sb on end
device ref hda on
+ register "pch_hda_audio_link_hda_enable" = "1"
register "pch_hda_idisp_codec_enable" = "1"
register "pch_hda_idisp_link_frequency" = "HDA_LINKFREQ_96MHZ"
register "pch_hda_idisp_link_tmode" = "HDA_TMODE_8T"
diff --git a/src/mainboard/system76/adl/variants/darp8/romstage.c b/src/mainboard/system76/adl/variants/darp8/romstage.c
index 3d6a5fb993..e6cf37fc74 100644
--- a/src/mainboard/system76/adl/variants/darp8/romstage.c
+++ b/src/mainboard/system76/adl/variants/darp8/romstage.c
@@ -17,7 +17,6 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
};
const bool half_populated = false;
- mupd->FspmConfig.PchHdaAudioLinkHdaEnable = 1;
mupd->FspmConfig.DmiMaxLinkSpeed = 4;
mupd->FspmConfig.GpioOverride = 0;
diff --git a/src/mainboard/system76/adl/variants/galp6/romstage.c b/src/mainboard/system76/adl/variants/galp6/romstage.c
index 3d6a5fb993..e6cf37fc74 100644
--- a/src/mainboard/system76/adl/variants/galp6/romstage.c
+++ b/src/mainboard/system76/adl/variants/galp6/romstage.c
@@ -17,7 +17,6 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
};
const bool half_populated = false;
- mupd->FspmConfig.PchHdaAudioLinkHdaEnable = 1;
mupd->FspmConfig.DmiMaxLinkSpeed = 4;
mupd->FspmConfig.GpioOverride = 0;