diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2023-07-14 19:49:05 +0200 |
|---|---|---|
| committer | Martin L Roth <gaumless@gmail.com> | 2023-07-17 03:27:47 +0000 |
| commit | 854491db63c9eb90a82d8453ea4ca5b97386567c (patch) | |
| tree | 6186aa0c6aae3fde6111936f945c923f2be57428 | |
| parent | 0c9549a058f2e785d60f3ccdce974d76af0307d0 (diff) | |
soc/amd/common/lpc/lpc_util: use PM register mapping in ACPIMMIO region
In all SoC lpc_early_init gets called either after a call to
enable_acpimmio_decode_pm04() or the ACPIMMIO mapping is already enabled
after reset on the SoC. This allows to use pm_read8 and pm_write8 that
use the ACPIMMIO mapping of the PM registers to set the PM_LPC_ENABLE
bit in the PM_LPC_GATING register instead of pm_io_read8 and
pm_io_write8 which won't work on Phoenix and Glinda due to the IO ports
used on older generations to access to the PM registers not being
implemented any more.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I8b31ec4e03a06796502c89e3c2cfaac2d41b0ed9
Reviewed-on: https://review.coreboot.org/c/coreboot/+/76461
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/soc/amd/common/block/lpc/lpc_util.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/amd/common/block/lpc/lpc_util.c b/src/soc/amd/common/block/lpc/lpc_util.c index 53bd090b6c..309825a841 100644 --- a/src/soc/amd/common/block/lpc/lpc_util.c +++ b/src/soc/amd/common/block/lpc/lpc_util.c @@ -347,9 +347,9 @@ static void lpc_enable_controller(void) u8 byte; /* Enable LPC controller */ - byte = pm_io_read8(PM_LPC_GATING); + byte = pm_read8(PM_LPC_GATING); byte |= PM_LPC_ENABLE; - pm_io_write8(PM_LPC_GATING, byte); + pm_write8(PM_LPC_GATING, byte); } void lpc_early_init(void) |