diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2020-09-11 14:53:03 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2020-09-12 14:59:12 +0000 |
| commit | 8395165eee0ab487993e78de52a63dbc669f6684 (patch) | |
| tree | b149c022e2eba051632c7f0fd486293cbd5bd1ed | |
| parent | c92524d488748bbad4c3d169c4b3fa103b27613a (diff) | |
soc/amd/picasso/uart: make index parameters unsigned
The UART index is never negative, so make it unsigned and drop the check
for the index to be non-negative.
BRANCH=zork
Change-Id: I38b5dad87f8af4fbe8ee1d919230efe48f68686c
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45292
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
| -rw-r--r-- | src/soc/amd/picasso/include/soc/uart.h | 4 | ||||
| -rw-r--r-- | src/soc/amd/picasso/uart.c | 8 |
2 files changed, 6 insertions, 6 deletions
diff --git a/src/soc/amd/picasso/include/soc/uart.h b/src/soc/amd/picasso/include/soc/uart.h index 3aac936dff..4e5619fa86 100644 --- a/src/soc/amd/picasso/include/soc/uart.h +++ b/src/soc/amd/picasso/include/soc/uart.h @@ -5,9 +5,9 @@ #include <types.h> -void set_uart_config(int idx); /* configure hardware of FCH UART selected by idx */ +void set_uart_config(unsigned int idx); /* configure hardware of FCH UART selected by idx */ void clear_uart_legacy_config(void); /* disable legacy I/O decode for FCH UART */ -uintptr_t get_uart_base(int idx); /* get MMIO base address of FCH UART */ +uintptr_t get_uart_base(unsigned int idx); /* get MMIO base address of FCH UART */ #endif /* __PICASSO_UART_H__ */ diff --git a/src/soc/amd/picasso/uart.c b/src/soc/amd/picasso/uart.c index d892333ca1..0bf7eb88d7 100644 --- a/src/soc/amd/picasso/uart.c +++ b/src/soc/amd/picasso/uart.c @@ -32,9 +32,9 @@ static const struct _uart_info { } }, }; -uintptr_t get_uart_base(int idx) +uintptr_t get_uart_base(unsigned int idx) { - if (idx < 0 || idx >= ARRAY_SIZE(uart_info)) + if (idx >= ARRAY_SIZE(uart_info)) return 0; return uart_info[idx].base; @@ -45,12 +45,12 @@ void clear_uart_legacy_config(void) write16((void *)FCH_UART_LEGACY_DECODE, 0); } -void set_uart_config(int idx) +void set_uart_config(unsigned int idx) { uint32_t uart_ctrl; uint16_t uart_leg; - if (idx < 0 || idx >= ARRAY_SIZE(uart_info)) + if (idx >= ARRAY_SIZE(uart_info)) return; program_gpios(uart_info[idx].mux, 2); |