diff options
| author | Sean Rhodes <sean@starlabs.systems> | 2023-07-07 14:27:28 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-08-10 14:04:40 +0000 |
| commit | 7d00b7c673c7ea1f95cf84f682a926045044b43f (patch) | |
| tree | 4517493014eccbf54ed1c35095801848c36c4a32 | |
| parent | c0c9fddaac7587ef772b546400b5a5d9af5f62bd (diff) | |
ec/starlabs/merlin/ite: Print version mismatches
If the version of the EC firmware in coreboot doesn't match
the firmware that the EC is running, print the versions.
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Change-Id: I55c09b8d5ffe8ca9135384c823d005b55cfd83d9
Reviewed-on: https://review.coreboot.org/c/coreboot/+/76380
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/ec/starlabs/merlin/ite.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/ec/starlabs/merlin/ite.c b/src/ec/starlabs/merlin/ite.c index 0f807debf8..62210ad863 100644 --- a/src/ec/starlabs/merlin/ite.c +++ b/src/ec/starlabs/merlin/ite.c @@ -79,10 +79,13 @@ void ec_mirror_flag(void) * that have CCG6, present on devices with TBT, but have a manual * flag for devices without it. */ + uint16_t ec_version = ec_get_version(); + if (CONFIG(EC_STARLABS_MIRROR_SUPPORT) && (CONFIG(SOC_INTEL_COMMON_BLOCK_TCSS) || get_uint_option("mirror_flag", 0)) && - (ec_get_version() != CONFIG_EC_STARLABS_MIRROR_VERSION)) { - printk(BIOS_ERR, "ITE: System and EC ROM version mismatch.\n"); + (ec_version != CONFIG_EC_STARLABS_MIRROR_VERSION)) { + printk(BIOS_ERR, "ITE: EC version 0x%x doesn't match coreboot version 0x%x.\n", + ec_version, CONFIG_EC_STARLABS_MIRROR_VERSION); ec_mirror_with_count(); } } |