summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTim Chen <tim-chen@quanta.corp-partner.google.com>2020-12-01 10:04:04 +0800
committerPatrick Georgi <pgeorgi@google.com>2021-01-15 11:22:13 +0000
commit77a7520385242bd2c9e323ecc74490b383c22f5e (patch)
tree60dcbfdc75203e7fc94f21d715ba5b398930c42a
parent9d20c84460093db15445540359e5362bfc914d1a (diff)
mb/google/dedede/var/metaknight: Add LTE power on/off sequence
LTE module used in metaknight has a specific power on/off sequence. GPIOs related to power sequence are: * GPP_A10 - LTE_PWR_OFF_R_ODL * GPP_H17 - LTE_RESET_R_ODL 1. Power on: GPP_A10 -> 20ms -> GPP_H17 2. Power off: GPP_H17 -> 10ms -> GPP_A10 3. Warm reset: GPP_A10 keeps high, GPP_H17 goes low at least 2ms Configure the GPIOs based on these requirements. BUG=b:173671094 TEST=Build and boot Metaknight to OS. Ensure that the LTE module power sequence requirements are met. Change-Id: Ibff16129dfe2f1de2b1519049244aba4b3123e52 Signed-off-by: Tim Chen <tim-chen@quanta.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/48195 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
-rw-r--r--src/mainboard/google/dedede/variants/metaknight/Makefile.inc5
-rw-r--r--src/mainboard/google/dedede/variants/metaknight/gpio.c21
-rw-r--r--src/mainboard/google/dedede/variants/metaknight/overridetree.cb15
-rw-r--r--src/mainboard/google/dedede/variants/metaknight/variant.c23
4 files changed, 64 insertions, 0 deletions
diff --git a/src/mainboard/google/dedede/variants/metaknight/Makefile.inc b/src/mainboard/google/dedede/variants/metaknight/Makefile.inc
new file mode 100644
index 0000000000..67a7ab235a
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/metaknight/Makefile.inc
@@ -0,0 +1,5 @@
+# SPDX-License-Identifier: GPL-2.0-only
+
+ramstage-y += gpio.c
+
+smm-y += variant.c
diff --git a/src/mainboard/google/dedede/variants/metaknight/gpio.c b/src/mainboard/google/dedede/variants/metaknight/gpio.c
new file mode 100644
index 0000000000..d6a7fd599f
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/metaknight/gpio.c
@@ -0,0 +1,21 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#include <baseboard/gpio.h>
+#include <baseboard/variants.h>
+#include <commonlib/helpers.h>
+#include <vendorcode/google/chromeos/chromeos.h>
+
+/* Pad configuration in ramstage*/
+static const struct pad_config gpio_table[] = {
+ /* A10 : WWAN_EN => LTE_PWR_OFF_ODL */
+ PAD_CFG_GPO(GPP_A10, 1, PWROK),
+
+ /* H17 : WWAN_RST_L => LTE_RESET_R_ODL */
+ PAD_CFG_GPO(GPP_H17, 0, PLTRST),
+};
+
+const struct pad_config *variant_override_gpio_table(size_t *num)
+{
+ *num = ARRAY_SIZE(gpio_table);
+ return gpio_table;
+}
diff --git a/src/mainboard/google/dedede/variants/metaknight/overridetree.cb b/src/mainboard/google/dedede/variants/metaknight/overridetree.cb
index 688ff9bcc7..322f72c788 100644
--- a/src/mainboard/google/dedede/variants/metaknight/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/metaknight/overridetree.cb
@@ -69,6 +69,16 @@ chip soc/intel/jasperlake
chip drivers/usb/acpi
device usb 0.0 on
chip drivers/usb/acpi
+ register "desc" = ""LTE""
+ register "type" = "UPC_TYPE_INTERNAL"
+ register "has_power_resource" = "1"
+ register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H17)"
+ register "reset_off_delay_ms" = "10"
+ register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A10)"
+ register "enable_delay_ms" = "20"
+ device usb 2.3 on end
+ end
+ chip drivers/usb/acpi
register "desc" = ""User Facing Camera""
register "type" = "UPC_TYPE_INTERNAL"
device usb 2.5 on end
@@ -78,6 +88,11 @@ chip soc/intel/jasperlake
register "type" = "UPC_TYPE_INTERNAL"
device usb 2.6 on end
end
+ chip drivers/usb/acpi
+ register "desc" = ""LTE""
+ register "type" = "UPC_TYPE_INTERNAL"
+ device usb 3.3 on end
+ end
end
end
end # USB xHCI
diff --git a/src/mainboard/google/dedede/variants/metaknight/variant.c b/src/mainboard/google/dedede/variants/metaknight/variant.c
new file mode 100644
index 0000000000..2540fc7f2a
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/metaknight/variant.c
@@ -0,0 +1,23 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#include <acpi/acpi.h>
+#include <baseboard/variants.h>
+#include <delay.h>
+#include <gpio.h>
+
+static void power_off_lte_module(void)
+{
+ gpio_output(GPP_H17, 0);
+ mdelay(10);
+ gpio_output(GPP_A10, 0);
+}
+
+void variant_smi_sleep(u8 slp_typ)
+{
+ /*
+ * Once the FW_CONFIG is provisioned, power off LTE module only under
+ * the situation where it is stuffed.
+ */
+ if (slp_typ == ACPI_S5)
+ power_off_lte_module();
+}