diff options
| author | Tim Wawrzynczak <twawrzynczak@chromium.org> | 2022-06-16 13:35:40 -0600 |
|---|---|---|
| committer | Martin L Roth <gaumless@tutanota.com> | 2022-06-18 04:33:25 +0000 |
| commit | 74ed2a5d609165dd1279d91d69dc811b59404d2e (patch) | |
| tree | 4fa29b9236ee56658d38adeb96599eb51cbbb411 | |
| parent | 6e28808612c23cb150f02dc3305f62cbc1c46873 (diff) | |
mb/google/brya/var/agah: Remove variant_finalize
The EEs and I misunderstood, and apparently the vfio-pci kernel driver
will turn off the dGPU when it sees it is unused, so coreboot should
leave the dGPU on so the kernel driver can save state before it shuts it
down.
TEST=Tested by ODM
Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Change-Id: I30b5dead7a5302f3385ddcaecfbf134c3bb68779
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65181
Reviewed-by: Robert Zieba <robertzieba@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
| -rw-r--r-- | src/mainboard/google/brya/variants/agah/variant.c | 17 |
1 files changed, 0 insertions, 17 deletions
diff --git a/src/mainboard/google/brya/variants/agah/variant.c b/src/mainboard/google/brya/variants/agah/variant.c index b1ab79f05e..cc9389284c 100644 --- a/src/mainboard/google/brya/variants/agah/variant.c +++ b/src/mainboard/google/brya/variants/agah/variant.c @@ -138,23 +138,6 @@ void variant_init(void) dgpu_power_sequence_on(); } -void variant_finalize(void) -{ - if (acpi_is_wakeup_s3() || !gpu_powered_on) - return; - - /* - * Because the dGPU is used here in a way similar to "hybrid graphics" - * modes, it is powered down here. The DRIVERS_GFX_NVIDIA_SAVE_BARS - * option is selected for agah, so the BARs will be saved to ACPI memory - * during its finalize routine. Thus, it is powered down here, as the - * proper resources have already been allocated. - */ - dgpu_power_sequence_off(); - - printk(BIOS_INFO, "GPU power sequenced off.\n"); -} - /* Save PCI BARs to the ACPI copy of the "saved PCI config space" */ void variant_fill_ssdt(const struct device *unused) { |