diff options
| author | Tarun Tuli <taruntuli@google.com> | 2023-05-29 12:56:41 +0000 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-05-31 18:47:23 +0000 |
| commit | 74a986db9fb2d900b5a11a11249b74afc2ee69e8 (patch) | |
| tree | b8be8208fa83d500d3fc9b3aa082cefd97b46830 | |
| parent | a3b46521fa0e20bc256da66801460577a9e20158 (diff) | |
mb/google/brya/acpi: FBVDD_PWR_EN should be inverted on Agah
The FBVDD_PWR_EN signal should be inverted in its control level
on Agah v.s. Hades. The original change covered the Hades
implementation, but needs to be updated to invert for Agah. This
change can be removed once we drop support for Agah.
BUG=b:280467267
TEST=built for Hades and Agah
Change-Id: I7f90c03b8d9b859004e5c124bf0a1f7b59921c3d
Signed-off-by: Tarun Tuli <taruntuli@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75530
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Subrata Banik <subratabanik@google.com>
| -rw-r--r-- | src/mainboard/google/brya/acpi/power.asl | 15 |
1 files changed, 12 insertions, 3 deletions
diff --git a/src/mainboard/google/brya/acpi/power.asl b/src/mainboard/google/brya/acpi/power.asl index 0371eda2ab..c4a84954f2 100644 --- a/src/mainboard/google/brya/acpi/power.asl +++ b/src/mainboard/google/brya/acpi/power.asl @@ -128,8 +128,12 @@ Method (GC6I, 0, Serialized) /* Deassert PG_GPU_ALLRAILS */ CTXS (GPIO_GPU_ALLRAILS_PG) - /* Deassert FBVDDQ Enable */ + /* Ramp down FBVDD - TODO: Remove Agah when board is dropped */ +#if CONFIG(BOARD_GOOGLE_AGAH) + STXS (GPIO_FBVDD_PWR_EN) +#else CTXS (GPIO_FBVDD_PWR_EN) +#endif /* Ramp down PEXVDD */ CTXS (GPIO_PEXVDD_PWR_EN) @@ -176,8 +180,13 @@ Method (GC6O, 0, Serialized) STXS (GPIO_PEXVDD_PWR_EN) GPPL (GPIO_PEXVDD_PG, 1, 4) - /* Assert FBVDDQ Enable */ - STXS (GPIO_FBVDD_PWR_EN) + /* Ramp up FBVDD - TODO: Remove Agah when board is dropped */ +#if CONFIG(BOARD_GOOGLE_AGAH) + CTXS (GPIO_FBVDD_PWR_EN) +#else + STXS (GPIO_FBVDD_PWR_EN) +#endif + /* Assert PG_GPU_ALLRAILS */ STXS (GPIO_GPU_ALLRAILS_PG) |