summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlex1 Kao <alex1_kao@pegatron.corp-partner.google.com>2021-07-16 19:00:10 +0800
committerPatrick Georgi <pgeorgi@google.com>2021-07-29 09:10:26 +0000
commit72cfaf05bf3442477aa2ee5b4835340a30281cde (patch)
tree289398f91de180e160e47408625b463b4034ffca
parent2597dc10d61f03ef336a86d190d8c906e8e12ef3 (diff)
mb/google/dedede/var/pirika: Configure I2C times to 380-400 kHz for touchpad
Configure I2C high / low time in the device tree to ensure I2C CLK runs accurately between 380 kHz and 400 kHz. Audio codec:388.91 kHz Touchpad:394.48 kHz BUG=b:193864546 BRANCH=dedede TEST=Build and check after tuning I2C clock is between 380 kHz and 400 kHz Signed-off-by: Alex1 Kao <alex1_kao@pegatron.corp-partner.google.com> Change-Id: Ia57c90ead44ceb0990878dc0566e595bae5a9099 Reviewed-on: https://review.coreboot.org/c/coreboot/+/56383 Reviewed-by: Kirk Wang <kirk_wang@pegatron.corp-partner.google.com> Reviewed-by: Karthik Ramasubramanian <kramasub@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/mainboard/google/dedede/variants/pirika/overridetree.cb24
1 files changed, 12 insertions, 12 deletions
diff --git a/src/mainboard/google/dedede/variants/pirika/overridetree.cb b/src/mainboard/google/dedede/variants/pirika/overridetree.cb
index df3fead3d9..fbbea1deb2 100644
--- a/src/mainboard/google/dedede/variants/pirika/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/pirika/overridetree.cb
@@ -9,9 +9,6 @@ chip soc/intel/jasperlake
#| | for TPM communication |
#| | before memory is up |
#| I2C0 | Trackpad |
- #| I2C1 | Digitizer |
- #| I2C2 | Touchscreen |
- #| I2C3 | Camera |
#| I2C4 | Audio |
#+-------------------+---------------------------+
register "common_soc_config" = "{
@@ -21,21 +18,24 @@ chip soc/intel/jasperlake
},
.i2c[0] = {
.speed = I2C_SPEED_FAST,
- },
- .i2c[1] = {
- .speed = I2C_SPEED_FAST,
- },
- .i2c[2] = {
- .speed = I2C_SPEED_FAST,
- },
- .i2c[3] = {
- .speed = I2C_SPEED_FAST,
+ .rise_time_ns = 260,
+ .fall_time_ns = 50,
},
.i2c[4] = {
.speed = I2C_SPEED_FAST,
+ .rise_time_ns = 260,
+ .fall_time_ns = 50,
},
}"
+ register "SerialIoI2cMode" = "{
+ [PchSerialIoIndexI2C0] = PchSerialIoPci,
+ [PchSerialIoIndexI2C1] = PchSerialIoDisabled,
+ [PchSerialIoIndexI2C2] = PchSerialIoDisabled,
+ [PchSerialIoIndexI2C3] = PchSerialIoDisabled,
+ [PchSerialIoIndexI2C4] = PchSerialIoPci,
+ }"
+
# USB Port Configuration
register "usb2_ports[2]" = "{
.enable = 1,