diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2023-08-02 18:48:25 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-08-04 14:07:03 +0000 |
| commit | 6b324d99192d543fb29e00bb40935893c85b24a8 (patch) | |
| tree | 68d9480911dd8c5642cb06cbf43537fa35da46df | |
| parent | bab976b85817526c8bf358c3af2d5ac410a575a1 (diff) | |
soc/amd/common/data_fabric_helper: add comment about cfg_inst_acc_en
Since all indirect data fabric register accesses will be non-broadcast
accesses that target a specific data fabric instance, the
cfg_inst_acc_en bit in the DF_FICAA_BIOS register will always be set
since that makes the indirect access target only a specific data fabric
instance.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I9aff01750c2c1e3506141b3ed293a980a64f8fac
Reviewed-on: https://review.coreboot.org/c/coreboot/+/76885
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
| -rw-r--r-- | src/soc/amd/common/block/data_fabric/data_fabric_helper.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/soc/amd/common/block/data_fabric/data_fabric_helper.c b/src/soc/amd/common/block/data_fabric/data_fabric_helper.c index fb4b26c049..1f0e2cf66b 100644 --- a/src/soc/amd/common/block/data_fabric/data_fabric_helper.c +++ b/src/soc/amd/common/block/data_fabric/data_fabric_helper.c @@ -13,7 +13,7 @@ static void data_fabric_set_indirect_address(uint8_t func, uint16_t reg, uint8_t instance_id) { - union df_ficaa ficaa = { .cfg_inst_acc_en = 1 }; + union df_ficaa ficaa = { .cfg_inst_acc_en = 1 }; /* target only specific instance */ /* convert register address to 32-bit register number */ ficaa.reg_num = reg >> 2; ficaa.func_num = func; |