summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlora Fu <flora.fu@mediatek.com>2021-11-09 16:42:05 +0800
committerFelix Held <felix-coreboot@felixheld.de>2021-11-11 14:34:44 +0000
commit66f2cbb19506b8740895f2d3c61319d3b5fcb168 (patch)
tree56e095c1227e2de6ad4c99e04827ed708caa47fe
parent67b91b9344af002515c7caf1b15747ffb4a2363e (diff)
soc/mediatek/mt8195: fix apusys coding defects
Use size_t for count variables. Reduce debug log level and fix typo. Fix commit: https://review.coreboot.org/c/coreboot/+/58794 BUG=b:203145462 BRANCH=cherry TEST=boot cherry correctly Signed-off-by: Flora Fu <flora.fu@mediatek.com> Change-Id: Ic03f71b7a9038edb5877ebd9b6aed5e9bd63c918 Reviewed-on: https://review.coreboot.org/c/coreboot/+/59038 Reviewed-by: Yu-Ping Wu <yupingso@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/soc/mediatek/mt8195/apusys.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/soc/mediatek/mt8195/apusys.c b/src/soc/mediatek/mt8195/apusys.c
index bc3c4abeca..fc95cab429 100644
--- a/src/soc/mediatek/mt8195/apusys.c
+++ b/src/soc/mediatek/mt8195/apusys.c
@@ -10,10 +10,10 @@ DEFINE_BITFIELD(NO_MPU, 16, 16)
static void dump_apusys_reg(void)
{
- int i;
+ size_t i;
for (i = 0; i < ARRAY_SIZE(mt8195_apu_mbox); i++) {
- printk(BIOS_INFO, "APU_MBOX %p = %#x\n",
+ printk(BIOS_DEBUG, "APU_MBOX %p = %#x\n",
(void *)&mt8195_apu_mbox[i]->mbox_func_cfg,
read32(&mt8195_apu_mbox[i]->mbox_func_cfg));
}
@@ -21,9 +21,9 @@ static void dump_apusys_reg(void)
void apusys_init(void)
{
- int i;
+ size_t i;
- /* Setup MBOX MPU for non secure access */
+ /* Set up MBOX MPU for non secure access */
for (i = 0; i < ARRAY_SIZE(mt8195_apu_mbox); i++)
SET32_BITFIELDS(&mt8195_apu_mbox[i]->mbox_func_cfg, NO_MPU, 1, LOCK, 1);