summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJon Murphy <jpmurphy@google.com>2022-03-22 11:51:56 -0600
committerFelix Held <felix-coreboot@felixheld.de>2022-03-23 19:38:09 +0000
commit65e43dd1a8aa19dac6cf2c33686e618de7d24b3b (patch)
tree2dbaadf27152e41424758c9a25083a88274f1137
parente2bde83a518d10fc6eaa7edca507daf271fdcf0a (diff)
mb/google/skyrim: Fix Backlight GPIO
Backlight GPIO was set to HIGH, when it should have been set LOW to enable the backlight in the embedded display. BUG=b:224618411 TEST=load on Skyrim proto1, observe backlight Signed-off-by: Jon Murphy <jpmurphy@google.com> Change-Id: Ife3335ca5a3c2517a6817fccf0544e5fcacb1f9d Reviewed-on: https://review.coreboot.org/c/coreboot/+/63003 Reviewed-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-by: Karthik Ramasubramanian <kramasub@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/mainboard/google/skyrim/variants/baseboard/gpio.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/google/skyrim/variants/baseboard/gpio.c b/src/mainboard/google/skyrim/variants/baseboard/gpio.c
index 204ddf65a2..d586405f0c 100644
--- a/src/mainboard/google/skyrim/variants/baseboard/gpio.c
+++ b/src/mainboard/google/skyrim/variants/baseboard/gpio.c
@@ -61,7 +61,7 @@ static const struct soc_amd_gpio base_gpio_table[] = {
/* EN_PP3300_TCHSCR */
PAD_GPO(GPIO_29, HIGH),
/* SOC_DISABLE_DISP_BL */
- PAD_GPO(GPIO_30, HIGH),
+ PAD_GPO(GPIO_30, LOW),
/* Unused */
PAD_NC(GPIO_31),
/* LPC_RST_L */