summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorElyes HAOUAS <ehaouas@noos.fr>2019-10-24 11:53:45 +0200
committerPatrick Georgi <pgeorgi@google.com>2019-10-25 10:06:45 +0000
commit5216b72a9918a5f3bd774f161399d135ffafd517 (patch)
treeeaa0d7e2f2cdb872cdb3074c3e1817acea21c200
parentfaaea998591338910657153780c090b204ee830e (diff)
ec/{compal,google,quanta}: Drop wrong _ADR objects
ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both." Change-Id: If3ee38f3eaa8e6d1c1b0393d0ba289f708e0ae5e Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/36293 Reviewed-by: Patrick Georgi <pgeorgi@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/ec/compal/ene932/acpi/superio.asl1
-rw-r--r--src/ec/google/wilco/acpi/ucsi.asl1
-rw-r--r--src/ec/quanta/it8518/acpi/superio.asl1
3 files changed, 0 insertions, 3 deletions
diff --git a/src/ec/compal/ene932/acpi/superio.asl b/src/ec/compal/ene932/acpi/superio.asl
index f152bbab57..034f6ded94 100644
--- a/src/ec/compal/ene932/acpi/superio.asl
+++ b/src/ec/compal/ene932/acpi/superio.asl
@@ -18,7 +18,6 @@
Device (SIO) {
Name (_HID, EisaId("PNP0A05"))
Name (_UID, 0)
- Name (_ADR, 0)
// Keyboard or AUX port (a.k.a Mouse)
#ifdef SIO_EC_ENABLE_PS2K
diff --git a/src/ec/google/wilco/acpi/ucsi.asl b/src/ec/google/wilco/acpi/ucsi.asl
index f69e5924e7..0d2c5a6336 100644
--- a/src/ec/google/wilco/acpi/ucsi.asl
+++ b/src/ec/google/wilco/acpi/ucsi.asl
@@ -19,7 +19,6 @@ Device (UCSI)
Name (_CID, EisaId ("PNP0CA0"))
Name (_DDN, "Wilco EC UCSI")
Name (_UID, One)
- Name (_ADR, Zero)
Name (_STA, 0xf)
/* Value written to EC control register to start UCSI command */
diff --git a/src/ec/quanta/it8518/acpi/superio.asl b/src/ec/quanta/it8518/acpi/superio.asl
index 4109cb5d55..8b93aa440e 100644
--- a/src/ec/quanta/it8518/acpi/superio.asl
+++ b/src/ec/quanta/it8518/acpi/superio.asl
@@ -19,7 +19,6 @@ Device (SIO)
{
Name (_HID, EisaId("PNP0A05"))
Name (_UID, 0)
- Name (_ADR, 0)
#ifdef SIO_EC_ENABLE_PS2K
Device (PS2K) // Keyboard