summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGwendal Grignou <gwendal@chromium.org>2022-10-17 12:33:35 -0700
committerNick Vaccaro <nvaccaro@google.com>2022-10-18 16:08:10 +0000
commit4ee037e8f0b305a164cddb9b9e8dc887b1211f86 (patch)
treedd90ad4def3049683e905d29ff0c59cc87a44792
parent630fb548869c507e6f02ad2cfdaa64ea427becc9 (diff)
mainboard/google: Remove ACPI ALS device
Remove the ACPI ALS device from the EC configuration for newer devices, because some do not have light sensors, and those who do have their ALS presented through the new EC sensor interface already. Inspired from commit ("f13e2501525f ("UPSTREAM: mainboard/google/eve: Remove ACPI ALS device") BUG=b:253967865 BRANCH=none TEST=Boot a device and ensure that 'acpi-als' device is not present in /sys/bus/iio/devices. Change-Id: Ibcfa9e8c5a4679d557150998fd255789d3f8a272 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/68493 Reviewed-by: Raul Rangel <rrangel@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/ec.h2
-rw-r--r--src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/ec.h3
-rw-r--r--src/mainboard/google/brya/variants/baseboard/skolas/include/baseboard/ec.h2
-rw-r--r--src/mainboard/google/dedede/variants/baseboard/include/baseboard/ec.h3
-rw-r--r--src/mainboard/google/fizz/variants/baseboard/include/baseboard/ec.h3
-rw-r--r--src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h3
-rw-r--r--src/mainboard/google/puff/variants/baseboard/include/baseboard/ec.h3
-rw-r--r--src/mainboard/google/puff/variants/dooly/include/variant/ec.h3
-rw-r--r--src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h3
-rw-r--r--src/mainboard/google/reef/variants/sand/include/variant/ec.h3
-rw-r--r--src/mainboard/google/volteer/variants/baseboard/include/baseboard/ec.h3
-rw-r--r--src/mainboard/google/zork/variants/baseboard/include/baseboard/ec.h3
12 files changed, 0 insertions, 34 deletions
diff --git a/src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/ec.h b/src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/ec.h
index 3c7fde5f54..61792e19f4 100644
--- a/src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/ec.h
+++ b/src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/ec.h
@@ -56,8 +56,6 @@
/*
* ACPI related definitions for ASL code.
*/
-/* Enable EC backed ALS device in ACPI */
-#define EC_ENABLE_ALS_DEVICE
/* Enable Keyboard Backlight */
#define EC_ENABLE_KEYBOARD_BACKLIGHT
/* Enable MKBP for buttons and switches */
diff --git a/src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/ec.h b/src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/ec.h
index fa5af03754..094d0c8929 100644
--- a/src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/ec.h
+++ b/src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/ec.h
@@ -62,9 +62,6 @@
/*
* ACPI related definitions for ASL code.
*/
-/* Enable EC backed ALS device in ACPI */
-#define EC_ENABLE_ALS_DEVICE
-
/* Enable Keyboard Backlight */
#define EC_ENABLE_KEYBOARD_BACKLIGHT
diff --git a/src/mainboard/google/brya/variants/baseboard/skolas/include/baseboard/ec.h b/src/mainboard/google/brya/variants/baseboard/skolas/include/baseboard/ec.h
index 3c7fde5f54..61792e19f4 100644
--- a/src/mainboard/google/brya/variants/baseboard/skolas/include/baseboard/ec.h
+++ b/src/mainboard/google/brya/variants/baseboard/skolas/include/baseboard/ec.h
@@ -56,8 +56,6 @@
/*
* ACPI related definitions for ASL code.
*/
-/* Enable EC backed ALS device in ACPI */
-#define EC_ENABLE_ALS_DEVICE
/* Enable Keyboard Backlight */
#define EC_ENABLE_KEYBOARD_BACKLIGHT
/* Enable MKBP for buttons and switches */
diff --git a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/ec.h
index 6ceaa391cc..2e75fce834 100644
--- a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/ec.h
+++ b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/ec.h
@@ -63,9 +63,6 @@
* ACPI related definitions for ASL code.
*/
-/* Enable EC backed ALS device in ACPI */
-#define EC_ENABLE_ALS_DEVICE
-
/* Enable MKBP for buttons and switches */
#define EC_ENABLE_MKBP_DEVICE
diff --git a/src/mainboard/google/fizz/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/fizz/variants/baseboard/include/baseboard/ec.h
index 504b6de614..1a2de1ffd8 100644
--- a/src/mainboard/google/fizz/variants/baseboard/include/baseboard/ec.h
+++ b/src/mainboard/google/fizz/variants/baseboard/include/baseboard/ec.h
@@ -42,9 +42,6 @@
* ACPI related definitions for ASL code.
*/
-/* Enable EC backed ALS device in ACPI */
-#define EC_ENABLE_ALS_DEVICE
-
/* Provide wake pin for EC */
#define EC_ENABLE_WAKE_PIN GPE_EC_WAKE
diff --git a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h
index 4760adc316..a1a71c0fd0 100644
--- a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h
+++ b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h
@@ -53,9 +53,6 @@
* ACPI related definitions for ASL code.
*/
-/* Enable EC backed ALS device in ACPI */
-#define EC_ENABLE_ALS_DEVICE
-
/* Enable EC backed PD MCU device in ACPI */
#define EC_ENABLE_PD_MCU_DEVICE
diff --git a/src/mainboard/google/puff/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/puff/variants/baseboard/include/baseboard/ec.h
index 4760adc316..a1a71c0fd0 100644
--- a/src/mainboard/google/puff/variants/baseboard/include/baseboard/ec.h
+++ b/src/mainboard/google/puff/variants/baseboard/include/baseboard/ec.h
@@ -53,9 +53,6 @@
* ACPI related definitions for ASL code.
*/
-/* Enable EC backed ALS device in ACPI */
-#define EC_ENABLE_ALS_DEVICE
-
/* Enable EC backed PD MCU device in ACPI */
#define EC_ENABLE_PD_MCU_DEVICE
diff --git a/src/mainboard/google/puff/variants/dooly/include/variant/ec.h b/src/mainboard/google/puff/variants/dooly/include/variant/ec.h
index 7d280c6edf..59fb3783c5 100644
--- a/src/mainboard/google/puff/variants/dooly/include/variant/ec.h
+++ b/src/mainboard/google/puff/variants/dooly/include/variant/ec.h
@@ -5,7 +5,4 @@
#include <puff/ec.h>
-/* Enable EC backed ALS device in ACPI */
-#define EC_ENABLE_ALS_DEVICE
-
#endif
diff --git a/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h
index 60cee863c9..ef75e7dd6d 100644
--- a/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h
+++ b/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h
@@ -48,9 +48,6 @@
* ACPI related definitions for ASL code.
*/
-/* Enable EC backed ALS device in ACPI */
-#define EC_ENABLE_ALS_DEVICE
-
/* Enable EC backed PD MCU device in ACPI */
#define EC_ENABLE_PD_MCU_DEVICE
diff --git a/src/mainboard/google/reef/variants/sand/include/variant/ec.h b/src/mainboard/google/reef/variants/sand/include/variant/ec.h
index 87d2887135..689b51f563 100644
--- a/src/mainboard/google/reef/variants/sand/include/variant/ec.h
+++ b/src/mainboard/google/reef/variants/sand/include/variant/ec.h
@@ -47,9 +47,6 @@
* ACPI related definitions for ASL code.
*/
-/* Enable EC backed ALS device in ACPI */
-#define EC_ENABLE_ALS_DEVICE
-
/* Enable EC backed Keyboard Backlight in ACPI */
#define EC_ENABLE_KEYBOARD_BACKLIGHT
diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/ec.h
index 6eca8bc5c2..8027fb1ffa 100644
--- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/ec.h
+++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/ec.h
@@ -53,9 +53,6 @@
* ACPI related definitions for ASL code.
*/
-/* Enable EC backed ALS device in ACPI */
-#define EC_ENABLE_ALS_DEVICE
-
/* Enable MKBP for buttons and switches */
#define EC_ENABLE_MKBP_DEVICE
diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/zork/variants/baseboard/include/baseboard/ec.h
index b8f881e5e6..f57a7609c4 100644
--- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/ec.h
+++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/ec.h
@@ -56,9 +56,6 @@
#define EC_ENABLE_LID_SWITCH
#define EC_ENABLE_WAKE_PIN EC_WAKE_GPI
-/* Enable EC backed ALS device in ACPI */
-#define EC_ENABLE_ALS_DEVICE
-
/* Enable EC backed PD MCU device in ACPI */
#define EC_ENABLE_PD_MCU_DEVICE